Page MenuHomePhabricator
Differential D22164

WebAssembly: Avoid implicit iterator conversions, NFC
ClosedPublic
Actions

Authored by dexonsmith on Jul 8 2016, 12:31 PM.

Details

Reviewers
sunfish
Summary

Avoid implicit conversions from MachineInstrBundleIterator to
MachineInstr* in the WebAssembly backend by preferring MachineInstr&
over MachineInstr*.

Diff Detail

Event Timeline

dexonsmith updated this revision to Diff 63296.Jul 8 2016, 12:31 PM
dexonsmith retitled this revision from to WebAssembly: Avoid implicit iterator conversions, NFC.
dexonsmith updated this object.
dexonsmith added a subscriber: llvm-commits.
Herald added subscribers: dschuff, jfb. · View Herald TranscriptJul 8 2016, 12:31 PM
sunfish accepted this revision.Jul 8 2016, 12:38 PM
sunfish added a reviewer: sunfish.
sunfish added a subscriber: sunfish.

Looks good, thanks!

This revision is now accepted and ready to land.Jul 8 2016, 12:38 PM
llvm-commits added a comment.Jul 8 2016, 12:44 PM

Committed in r274912.

dexonsmith closed this revision.Jul 8 2016, 12:44 PM

Revision Contents
Changeset List

PathSize
lib/
Target/
WebAssembly/
14 lines
8 lines
41 lines

Diff 63296

View Options

lib/Target/WebAssembly/WebAssemblyArgumentMove.cpp

Loading...
View Options

lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp

Loading...
View Options

lib/Target/WebAssembly/WebAssemblyRegStackify.cpp

Loading...