This is an archive of the discontinued LLVM Phabricator instance.

[SystemZ] Recognize Load On Condition Immediate (LOCHI/LOGHI) opportunities
ClosedPublic

Authored by RolandF on Jul 7 2016, 3:42 PM.

Details

Summary

Add support for the z13 instructions LOCHI and LOCGHI which conditionally load immediate values. Add target instruction info hooks so that if conversion will allow predication of LHI/LGHI.

Diff Detail

Repository
rL LLVM

Event Timeline

RolandF updated this revision to Diff 63150.Jul 7 2016, 3:42 PM
RolandF retitled this revision from to [SystemZ] Recognize Load On Condition Immediate (LOCHI/LOGHI) opportunities.
RolandF updated this object.
RolandF added a reviewer: uweigand.
RolandF added a subscriber: zhanjunl.
uweigand edited edge metadata.Jul 8 2016, 8:51 AM

Please also add test cases for the *assembler* for the new instructions (in test/MC/SystemZ/insn-good-z13.s, as well as checks for invalid operands in insn-bad-z13.s, and checks for missing feature in insn-bad-zEC12.s).

Otherwise, this looks all good to me, thanks!

RolandF updated this revision to Diff 63526.Jul 11 2016, 9:51 AM
RolandF edited edge metadata.

Added assembler tests.

uweigand accepted this revision.Jul 11 2016, 10:24 AM
uweigand edited edge metadata.

LGTM, thanks!

This revision is now accepted and ready to land.Jul 11 2016, 10:24 AM
This revision was automatically updated to reflect the committed changes.