Page MenuHomePhabricator

Clang-format LoadStoreVectorizer
ClosedPublic

Authored by asbirlea on Jul 7 2016, 12:00 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea updated this revision to Diff 63113.Jul 7 2016, 12:00 PM
asbirlea retitled this revision from to Clang-format LoadStoreVectorizer.
asbirlea updated this object.
asbirlea added reviewers: llvm-commits, jlebar, arsenm.
jlebar added inline comments.Jul 7 2016, 12:53 PM
lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
837 ↗(On Diff #63113)

This is ugly. Does clang-format like it better if we put braces inside the DEBUG()?

DEBUG({
  dbgs() << ...;
  for (...) {}
});

Same above for many of the other multi-instruction DEBUGs.

asbirlea added inline comments.Jul 7 2016, 12:56 PM
lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
837 ↗(On Diff #63113)

Looks like yes, it does. Updating shortly.

asbirlea updated this revision to Diff 63119.Jul 7 2016, 1:00 PM

Add braces for cleaner reformat.

jlebar added inline comments.Jul 7 2016, 1:04 PM
lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
455 ↗(On Diff #63119)

Probably should have braces here, too.

844 ↗(On Diff #63119)

Do we need braces around the for loop? llvm style usually leaves them out.

asbirlea added inline comments.Jul 7 2016, 1:10 PM
lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
455 ↗(On Diff #63119)

TBH I like more the formatting without. Either works though.

844 ↗(On Diff #63119)

Removing those.

jlebar accepted this revision.Jul 7 2016, 1:13 PM
jlebar edited edge metadata.
This revision is now accepted and ready to land.Jul 7 2016, 1:13 PM
asbirlea updated this revision to Diff 63122.Jul 7 2016, 1:13 PM
asbirlea edited edge metadata.

Minor formatting.

This revision was automatically updated to reflect the committed changes.