This is an archive of the discontinued LLVM Phabricator instance.

[LLD/MachO] Add a couple of missing braces
ClosedPublic

Authored by davide on Jul 4 2016, 2:05 PM.

Reviewers

Commits

Summary

Found by visual inspection. Hope it makes sense to you guys =)

davide retitled this revision from to [LLD/MachO] Add a couple of missing braces.

davide updated this object.

davide added reviewers: pete, lhames.

davide added a subscriber: llvm-commits.

ping.

Double-checked that this makes sense.

This revision is now accepted and ready to land.Jul 20 2016, 3:04 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lld/

trunk/

lib/

Driver/

3 lines

Show First 20 Lines • Show All 733 Lines • ▼ Show 20 Lines	case llvm::MachO::MH_EXECUTE:
if ((minOSVersion < 0x00040200) &&		if ((minOSVersion < 0x00040200) &&
(pie->getOption().getID() == OPT_pie)) {		(pie->getOption().getID() == OPT_pie)) {
diagnostics << "-pie can only be used when targeting "		diagnostics << "-pie can only be used when targeting "
"iOS 4.2 or later\n";		"iOS 4.2 or later\n";
return false;		return false;
}		}
break;		break;
case MachOLinkingContext::OS::iOS_simulator:		case MachOLinkingContext::OS::iOS_simulator:
if (pie->getOption().getID() == OPT_no_pie)		if (pie->getOption().getID() == OPT_no_pie) {
diagnostics << "iOS simulator programs must be built PIE\n";		diagnostics << "iOS simulator programs must be built PIE\n";
return false;		return false;
		}
break;		break;
case MachOLinkingContext::OS::unknown:		case MachOLinkingContext::OS::unknown:
break;		break;
}		}
ctx.setPIE(pie->getOption().getID() == OPT_pie);		ctx.setPIE(pie->getOption().getID() == OPT_pie);
break;		break;
case llvm::MachO::MH_PRELOAD:		case llvm::MachO::MH_PRELOAD:
break;		break;
▲ Show 20 Lines • Show All 463 Lines • Show Last 20 Lines