Page MenuHomePhabricator

[ELF] Initial support for symbol assignment in linker scripts
AbandonedPublic

Authored by davide on Jul 3 2016, 7:47 PM.

Details

Reviewers
ruiu
Summary

This just adds the symbol to the symboltable but doesn't update st_value.
I'd prefer to do that in my next patch. I'm not quite familiar with the linker script parsing code so a careful review would be appreciated. Thanks!

Diff Detail

Event Timeline

davide updated this revision to Diff 62647.Jul 3 2016, 7:47 PM
davide retitled this revision from to [ELF] Initial support for symbol assignment in linker scripts.
davide updated this object.
davide added a reviewer: ruiu.
davide added a subscriber: llvm-commits.
grimar added a subscriber: grimar.Jul 4 2016, 1:35 AM

As far I remember, linker script implementation story was suspended with idea that redesign is required at first (please see comments for D19190).
My suggestion for redesign was here: D19976, it is long time without movements.

So I just not sure is it worth to continue that patch when it seems there is no clear desicion about LS design. At least that moment should be
clarified at first I think.

grimar added a comment.Jul 4 2016, 5:05 AM

btw, PROVIDE command implemented in mentioned "[ELF] - Implemented PROVIDE linker script command." (D19190) is
very close to this I think. I would probably combine the PROVIDE tag and such assignments.
But again we need to clarify the design at first.

davide abandoned this revision.Jul 4 2016, 8:19 AM

btw, PROVIDE command implemented in mentioned "[ELF] - Implemented PROVIDE linker script command." (D19190) is
very close to this I think. I would probably combine the PROVIDE tag and such assignments.
But again we need to clarify the design at first.

OK, I'm abandoning this for now then.
I'll try to take a look at D19190. Thanks!