Page MenuHomePhabricator
Differential D21961

AMDGPU: Fix folding SGPRs into madak/madmk src0
ClosedPublic
Actions

Authored by arsenm on Jul 3 2016, 1:08 PM.

Details

Reviewers
• tstellarAMD
mareko
Summary

Because of the special immediate operand, the constant
bus is already used so SGPRs are never useful.




r263212 changed the name of the immediate operand, which

broke the verifier check for the restriction.
Diff Detail
Event Timeline
arsenm updated this revision to Diff 62635.Jul 3 2016, 1:08 PM
arsenm retitled this revision from  to AMDGPU: Fix folding SGPRs into madak/madmk src0.
arsenm updated this object.
arsenm added reviewers: • tstellarAMD, mareko.
arsenm added a subscriber: llvm-commits.
Herald added subscribers: kzhuravl, arsenm.  ·  View Herald TranscriptJul 3 2016, 1:08 PM
mareko edited edge metadata.Jul 3 2016, 2:18 PM
Thanks. This fixes incorrect rendering in Borderlands 2.
• spstarr added a subscriber: • spstarr.Jul 3 2016, 3:13 PM
Tested-By: Shawn Starr



Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=96672
mareko mentioned this in D19091: AMDGPU: Run SIFoldOperands after PeepholeOptimizer.Jul 4 2016, 10:00 AM
• tstellarAMD accepted this revision.Jul 4 2016, 12:20 PM
• tstellarAMD edited edge metadata.
LGTM.
This revision is now accepted and ready to land.Jul 4 2016, 12:20 PM
arsenm closed this revision.Jul 5 2016, 10:16 AM
r274564
Revision Contents
Changeset List
PathSize
lib/
Target/
AMDGPU/
7 lines
7 lines
14 lines
4 lines
test/
CodeGen/
AMDGPU/
29 lines
Diff 62635
View Options
lib/Target/AMDGPU/AMDGPUInstructions.td
Loading...
View Options
lib/Target/AMDGPU/SIDefines.h
Loading...
View Options
lib/Target/AMDGPU/SIInstrInfo.cpp
Loading...
View Options
lib/Target/AMDGPU/SIInstrInfo.td
Loading...
View Options
test/CodeGen/AMDGPU/madak.ll
Loading...