This is an archive of the discontinued LLVM Phabricator instance.

Differential D21825

Driver: Forbid -fthinlto-index with output formats other than object files.
Needs ReviewPublic

Authored by pcc on Jun 28 2016, 6:00 PM.

Details

Reviewers
tejohnson
Summary

The other output formats aren't really useful to end users. The equivalent
functionality can still be accessed by developers with tools such as llvm-lto.

Diff Detail

Event Timeline

pcc updated this revision to Diff 62158.Jun 28 2016, 6:00 PM
pcc retitled this revision from to Driver: Forbid -fthinlto-index with output formats other than object files..
pcc updated this object.
pcc added a reviewer: tejohnson.
pcc added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini. · View Herald TranscriptJun 28 2016, 6:00 PM
pcc mentioned this in D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution..Jun 28 2016, 6:06 PM
pcc added a comment.Jul 13 2016, 7:58 PM

Ping.

Revision Contents

PathSize
lib/
Driver/
3 lines
test/
Driver/
8 lines

Diff 62158

lib/Driver/Tools.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 3,889 Lines • ▼ Show 20 Lines if (isa<AnalyzeJobAction>(JA)) {
if (D.isUsingLTO()) if (D.isUsingLTO())
Args.AddLastArg(CmdArgs, options::OPT_flto, options::OPT_flto_EQ); Args.AddLastArg(CmdArgs, options::OPT_flto, options::OPT_flto_EQ);
} }
if (const Arg *A = Args.getLastArg(options::OPT_fthinlto_index_EQ)) { if (const Arg *A = Args.getLastArg(options::OPT_fthinlto_index_EQ)) {
if (!types::isLLVMIR(Input.getType())) if (!types::isLLVMIR(Input.getType()))
D.Diag(diag::err_drv_argument_only_allowed_with) << A->getAsString(Args) D.Diag(diag::err_drv_argument_only_allowed_with) << A->getAsString(Args)
<< "-x ir"; << "-x ir";
if (!isa<AssembleJobAction>(JA))
D.Diag(diag::err_drv_argument_only_allowed_with) << A->getAsString(Args)
<< "-c";
Args.AddLastArg(CmdArgs, options::OPT_fthinlto_index_EQ); Args.AddLastArg(CmdArgs, options::OPT_fthinlto_index_EQ);
} }
// Embed-bitcode option. // Embed-bitcode option.
if (C.getDriver().embedBitcodeEnabled() && if (C.getDriver().embedBitcodeEnabled() &&
(isa<BackendJobAction>(JA) || isa<AssembleJobAction>(JA))) { (isa<BackendJobAction>(JA) || isa<AssembleJobAction>(JA))) {
// Add flags implied by -fembed-bitcode. // Add flags implied by -fembed-bitcode.
Args.AddLastArg(CmdArgs, options::OPT_fembed_bitcode_EQ); Args.AddLastArg(CmdArgs, options::OPT_fembed_bitcode_EQ);
▲ Show 20 Lines • Show All 7,291 Lines • Show Last 20 Lines

test/Driver/thinlto_backend.c

// RUN: %clang -O2 %s -flto=thin -c -o %t.o // RUN: %clang -O2 %s -flto=thin -c -o %t.o
// RUN: llvm-lto -thinlto -o %t %t.o // RUN: llvm-lto -thinlto -o %t %t.o
// -fthinlto_index should be passed to cc1 // -fthinlto_index should be passed to cc1
// RUN: %clang -O2 -o %t1.o -x ir %t.o -c -fthinlto-index=%t.thinlto.bc -### 2>&1 | FileCheck %s -check-prefix=CHECK-THINLTOBE-ACTION // RUN: %clang -O2 -o %t1.o -x ir %t.o -c -fthinlto-index=%t.thinlto.bc -### 2>&1 | FileCheck %s -check-prefix=CHECK-THINLTOBE-ACTION
// CHECK-THINLTOBE-ACTION: -fthinlto-index= // CHECK-THINLTOBE-ACTION: -fthinlto-index=
// Ensure clang driver gives the expected error for incorrect input type // Ensure clang driver gives the expected error for incorrect input type
// RUN: not %clang -O2 -o %t1.o %s -c -fthinlto-index=%t.thinlto.bc 2>&1 | FileCheck %s -check-prefix=CHECK-WARNING // RUN: not %clang -O2 -o %t1.o %s -c -fthinlto-index=%t.thinlto.bc 2>&1 | FileCheck %s -check-prefix=CHECK-ERR1
// CHECK-WARNING: error: invalid argument '-fthinlto-index={{.*}}' only allowed with '-x ir' // CHECK-ERR1: error: invalid argument '-fthinlto-index={{.*}}' only allowed with '-x ir'
// And for incorrect output type
// RUN: not %clang -O2 -o %t1.o -x ir %s -S -fthinlto-index=%t.thinlto.bc 2>&1 | FileCheck %s -check-prefix=CHECK-ERR2
// CHECK-ERR2: error: invalid argument '-fthinlto-index={{.*}}' only allowed with '-c'