This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Change fdiv lowering based on !fpmath metadata
ClosedPublic

Authored by arsenm on Jun 27 2016, 11:54 AM.

Details

Reviewers
tstellarAMD
Summary

If 2.5 ulp is acceptable, denormals are not required, and
isn't a reciprocal which will already be handled, replace
with a faster fdiv.

Simplify the lowering tests by using per function
subtarget features.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 61997.Jun 27 2016, 11:54 AM
arsenm retitled this revision from to AMDGPU: Change fdiv lowering based on !fpmath metadata.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
mareko added a subscriber: mareko.Jul 11 2016, 9:21 AM

FYI, Mesa already sets !fpmath 2.5 on fdiv.

It looks good to me, but I'm not able to tell if all the code is correct.

tstellarAMD accepted this revision.Jul 18 2016, 6:57 AM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 18 2016, 6:57 AM
arsenm closed this revision.Jul 19 2016, 4:25 PM

r276051