This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Let user specify extra stats file.
ClosedPublic

Authored by metzman on Jun 26 2016, 7:24 PM.

Details

Summary

If AFL_DRIVER_EXTRA_STATS_FILENAME is set and valid, write to it peak_rss_mb and slowest_unit_time_sec. These are both stats that libFuzzer can print but afl cannot.

Diff Detail

Event Timeline

metzman updated this revision to Diff 61923.Jun 26 2016, 7:24 PM
metzman retitled this revision from to [libFuzzer] Let user specify max_len and extra stats file..
metzman updated this object.
metzman added reviewers: kcc, aizatsky.
metzman added a subscriber: llvm-commits.
metzman updated this object.Jun 26 2016, 7:29 PM
metzman updated this revision to Diff 61924.Jun 26 2016, 7:43 PM

Remove unneeded unset of AFL_MAX_LEN in test and undo unnecessary comment change.

metzman updated this revision to Diff 61926.Jun 26 2016, 7:47 PM

Remove unneded unsetting of ASAN_OPTIONS in test.

aizatsky requested changes to this revision.Jun 28 2016, 11:27 AM
aizatsky edited edge metadata.
aizatsky added inline comments.
lib/Fuzzer/test/afl-driver.test
12

Please break test into multiple by feature. This makes debugging problems later much easier.

This revision now requires changes to proceed.Jun 28 2016, 11:27 AM

The CL is simple enough. But I'd still like to see new tests in afl-driver-stats-filename.test not in afl-driver.test

metzman updated this revision to Diff 62134.Jun 28 2016, 1:40 PM
metzman edited edge metadata.

Breakup afl-driver.test, remove max_len feature and fix extra stats test.

  1. Split afl-driver.test into two files afl-driver-extra-stats.test and afl-driver-stderr.test
  2. Remove AFL_DRIVER_MAX_LEN feature from earlier update.
  3. Remove hardcoded locations from extra stats test.
metzman updated this object.Jun 28 2016, 1:40 PM
metzman edited edge metadata.
metzman retitled this revision from [libFuzzer] Let user specify max_len and extra stats file. to [libFuzzer] Let user specify extra stats file..
aizatsky accepted this revision.Jun 28 2016, 1:42 PM
aizatsky edited edge metadata.

Thanks for splitting the test.

This revision is now accepted and ready to land.Jun 28 2016, 1:42 PM
metzman planned changes to this revision.Jun 30 2016, 11:33 AM
metzman accepted this revision.
metzman marked an inline comment as done.
metzman added a reviewer: metzman.
aizatsky accepted this revision.Jun 30 2016, 1:19 PM
This revision was automatically updated to reflect the committed changes.