Details
Diff Detail
Event Timeline
This fix does not work without something along the lines of D21649, I'll re-upload with a better fix.
Disconnect from existing platform connection to prevent extra hanging connections
This is good practice on all debug servers, and required for debug servers which
can't handle more than one simultaneous platform mode connection.
Hi all,
If memory serves me correctly, I originally wrote this test. I don't think it buys us anything to run it against remote targets. I think a better approach here is to just exclude it when running against a remote.
We could instead use:
@decorator.skipIfRemote
I was wondering that as well. I thought there might be some value to testing that the "disconnect->change platform->reconnect" path worked though. I have no problem disabling if that doesn't seem useful though.
I think that kind of test sounds good, but I would separate that into a test that is focused on that element rather than conflating it with this one.
If you can switch this over to skipping the test on remote systems (should be @decorators.skipIfRemote IIRC), that would be ideal.