Page MenuHomePhabricator

Don't run TestImageListMultiArchitecture during remote test suite
ClosedPublic

Authored by fjricci on Jun 23 2016, 9:50 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci updated this revision to Diff 61689.Jun 23 2016, 9:50 AM
fjricci retitled this revision from to Make sure to reset to correct platform after TestImageListMultiArchitecture.
fjricci updated this object.
fjricci added reviewers: clayborg, tfiala, zturner.
fjricci added subscribers: lldb-commits, sas.
clayborg accepted this revision.Jun 23 2016, 11:02 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2016, 11:02 AM
fjricci planned changes to this revision.Jun 23 2016, 1:24 PM

This fix does not work without something along the lines of D21649, I'll re-upload with a better fix.

fjricci updated this revision to Diff 61717.Jun 23 2016, 1:38 PM
fjricci edited edge metadata.

Disconnect from existing platform connection to prevent extra hanging connections

This is good practice on all debug servers, and required for debug servers which
can't handle more than one simultaneous platform mode connection.

This revision is now accepted and ready to land.Jun 23 2016, 1:38 PM
tfiala edited edge metadata.Jun 23 2016, 2:51 PM

Hi all,

If memory serves me correctly, I originally wrote this test. I don't think it buys us anything to run it against remote targets. I think a better approach here is to just exclude it when running against a remote.

We could instead use:

@decorator.skipIfRemote

I was wondering that as well. I thought there might be some value to testing that the "disconnect->change platform->reconnect" path worked though. I have no problem disabling if that doesn't seem useful though.

I was wondering that as well. I thought there might be some value to testing that the "disconnect->change platform->reconnect" path worked though. I have no problem disabling if that doesn't seem useful though.

I think that kind of test sounds good, but I would separate that into a test that is focused on that element rather than conflating it with this one.

If you can switch this over to skipping the test on remote systems (should be @decorators.skipIfRemote IIRC), that would be ideal.

fjricci planned changes to this revision.Jun 23 2016, 6:48 PM

That's reasonable, will do.

fjricci updated this revision to Diff 61803.Jun 24 2016, 9:05 AM
fjricci edited edge metadata.

Skip test on remote platforms

This revision is now accepted and ready to land.Jun 24 2016, 9:05 AM
fjricci retitled this revision from Make sure to reset to correct platform after TestImageListMultiArchitecture to Don't run TestImageListMultiArchitecture during remote test suite.Jun 24 2016, 9:05 AM
fjricci updated this object.
tfiala accepted this revision.Jun 24 2016, 9:26 AM
tfiala edited edge metadata.

Thanks, looks good!

This revision was automatically updated to reflect the committed changes.