[clang-tidy] boost-use-to-string arg expr location bugfix

[Prazek]

Summary

getExprLoc returns location after dot for member call.

[Prazek]

• small fix

[Prazek]

ping anyone. This is nobrainer fix.

[alexfh]

LG with a couple of nits.

test/clang-tidy/boost-use-to-string.cpp

154

"wierd" is weird ;)

161

nit: The {{..}} part doesn't seem to be useful. Above as well.

[alexfh]

test/clang-tidy/boost-use-to-string.cpp

154

I should have been more clear in the first place: please fix the typo.

http://www.google.com/#q=wierd

[Prazek]

test/clang-tidy/boost-use-to-string.cpp

154

sorry, I pushed the patch immidiatelly when I saw that I missed your comment.

clang-tidy/boost/UseToStringCheck.cpp

auto Diag =
       diag(Loc, "use std::to_%0 instead of boost::lexical_cast<std::%0>")
       << StringType;
 
   if (Loc.isMacroID())
     return;
 
   Diag << FixItHint::CreateReplacement(
       CharSourceRange::getCharRange(Call->getLocStart(),
-                                    Call->getArg(0)->getExprLoc()),
+                                    Call->getArg(0)->getLocStart()),
       (llvm::Twine("std::to_") + StringType + "(").str());
 }
 
 } // namespace boost
 } // namespace tidy
 } // namespace clang

test/clang-tidy/boost-use-to-string.cpp

 
 void no_warnings() {
   fun(boost::lexical_cast<std::string>("abc"));
   fun(boost::lexical_cast<std::wstring>("abc"));
   fun(boost::lexical_cast<std::string>(my_weird_type{}));
   string_as_T<int>();
   string_as_T<std::string>();
 }
+
+struct Fields {
+  int integer;
+  float floating;
+  Fields* wierd;
+  const int &getConstInteger() const {return integer;}
+};
+
+void testFields() {
+  Fields fields;
+  auto s1 = boost::lexical_cast<std::string>(fields.integer);
+  // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: use std::to_string{{..}}
+  // CHECK-FIXES: auto s1 = std::to_string(fields.integer);
+
+  auto s2 = boost::lexical_cast<std::string>(fields.floating);
+  auto s3 = boost::lexical_cast<std::string>(fields.wierd);
+  auto s4 = boost::lexical_cast<std::string>(fields.getConstInteger());
+  // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: use std::to_string{{..}}
+  // CHECK-FIXES: auto s4 = std::to_string(fields.getConstInteger());
+}