This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] boost-use-to-string arg expr location bugfix
ClosedPublic

Authored by Prazek on Jun 23 2016, 4:52 AM.

Diff Detail

Event Timeline

Prazek updated this revision to Diff 61663.Jun 23 2016, 4:52 AM
Prazek retitled this revision from to [clang-tidy] boost-use-to-string arg expr location bugfix.
Prazek updated this object.
Prazek added reviewers: alexfh, sbenza, hokein.
Prazek added a subscriber: cfe-commits.
Prazek updated this revision to Diff 61665.Jun 23 2016, 5:02 AM
  • small fix

ping anyone. This is nobrainer fix.

alexfh accepted this revision.Jun 26 2016, 11:04 AM
alexfh edited edge metadata.

LG with a couple of nits.

test/clang-tidy/boost-use-to-string.cpp
154

"wierd" is weird ;)

161

nit: The {{..}} part doesn't seem to be useful. Above as well.

This revision is now accepted and ready to land.Jun 26 2016, 11:04 AM
This revision was automatically updated to reflect the committed changes.
alexfh added inline comments.Jun 28 2016, 1:56 AM
test/clang-tidy/boost-use-to-string.cpp
154

I should have been more clear in the first place: please fix the typo.

http://www.google.com/#q=wierd

Prazek marked 3 inline comments as done.Jul 22 2016, 1:24 PM
Prazek added inline comments.
test/clang-tidy/boost-use-to-string.cpp
154

sorry, I pushed the patch immidiatelly when I saw that I missed your comment.