Reduce size in memory. This is very helpful in a multi-module setups.

[v.g.vassilev]

ping...

[v.g.vassilev]

@lhames: ping2...

[v.g.vassilev]

ping2...

[lhames]

Hi Vassil,

Sorry for the delayed reply.

What's the rationale behind this change? My (very limited) understanding of unordered_map is that '4' is the initial number of buckets to create, but I would have expected that to raise the memory consumption (assuming less than four are needed in practice) or leave it unaffected?

What do you mean by a multi-module use case? (Multiple modules in a single RuntimeDyld instance?)
Have you profiled other use-cases?

Cheers,
Lang.

[v.g.vassilev]

Hi Lang,

Thanks for the reply.

Based on our profiling we found out that the Relocations allocated storage which we didn't need. It used to be a DenseMap and now it indeed changed to unordered_map. Maybe we don't need this anymore.

@karies should be able to give more details once he is back from vacation.

Cheers,
Vassil

[karies]

Indeed, this is superseded by Keno's change from DenseMap to std::unordered_map. Sorry for the noise...

[v.g.vassilev]

Clarified.

lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h

 public:
   RuntimeDyldImpl(RuntimeDyld::MemoryManager &MemMgr,
                   RuntimeDyld::SymbolResolver &Resolver)
-    : MemMgr(MemMgr), Resolver(Resolver), Checker(nullptr),
+    : MemMgr(MemMgr), Resolver(Resolver), Checker(nullptr), Relocations(4),
       ProcessAllSections(false), HasError(false) {
   }