- User Since
- Dec 14 2015, 11:24 PM (223 w, 5 d)
Feb 6 2018
Does this qualify? https://github.com/root-project/root/blob/master/.clang-format#L84
# You want this : enable it if you have https://reviews.llvm.org/D32525 # SpaceBeforeColon: false
in ROOT's .clang-format.
Aug 7 2017
...and remove FIXME.
Only write out an ampersand if needed to make parameter and argument match types.
Increase test coverage (including a text suggested by @rjmccall using an array param) and adjust existing tests' expected diagnostics to follow this change.
Aug 5 2017
Jul 7 2017
Jul 5 2017
To be clear: emitting annotations will trigger the determination of PresumedLocs. As part of that (but not the first part, IIRC) SourceManager::getBufferName(() will be called which will trigger the fopen of the file, just to get its name. Another task of PresumedLoc is to determine the line number which triggers an fopen; @v.g.vassilev is looking into a possible solution for that one.
Jul 3 2017
- I think the part Val.getBitWidth() == 64 likely needs rewording, although I don't know how
- I can show the motivation, not sure whether that qualifies as a test case:
Jun 22 2017
I cannot handle Phabricator. Ignore this, Vassil will help on D34444!
Jun 21 2017
For the record, here's what GCC does (from https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#C_002b_002b-Dialect-Options which probably has a typo, the second -Wnoexcept is likely meant to be -Wnoexcept-type): "Enabled by -Wabi and -Wc++1z-compat." -Wc++1z-compat is probably meant to enable a group out of which -Wnoexcept-type is just one (currently the only one as far as I can see). FWIW, we notice the missing -Wno-noexcept-type but not -Wc++1z-compat.
Apologies for the slow response.
Feb 16 2017
Aug 29 2016
Indeed, this is superseded by Keno's change from DenseMap to std::unordered_map. Sorry for the noise...
Jun 15 2016
May 9 2016
Regarding the concerns raised by @akyrtzi : maybe it's a question of making the completer interface useful at low cost (with filtering for generic use cases and less ASTReading) versus not breaking existing use cases (fuzzy match). Would you still object to this change if the filtering could be disabled in the CodeCompleteConsumer?
Apr 28 2016
Feb 5 2016
Because of previous review subscriptions...
Feb 3 2016
Committed as r259637