Page MenuHomePhabricator

karies (Axel Naumann)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2015, 11:24 PM (201 w, 1 d)

Recent Activity

Feb 6 2018

karies added a comment to D32525: [clang-format] Add SpaceBeforeColon option.

Does this qualify? https://github.com/root-project/root/blob/master/.clang-format#L84

# You want this : enable it if you have https://reviews.llvm.org/D32525
# SpaceBeforeColon: false

in ROOT's .clang-format.

Feb 6 2018, 8:01 AM

Aug 7 2017

karies updated the diff for D36368: Fix type printing of array template args.

...and remove FIXME.

Aug 7 2017, 3:00 AM · Restricted Project, Restricted Project
karies updated the diff for D36368: Fix type printing of array template args.

Only write out an ampersand if needed to make parameter and argument match types.
Increase test coverage (including a text suggested by @rjmccall using an array param) and adjust existing tests' expected diagnostics to follow this change.

Aug 7 2017, 2:59 AM · Restricted Project, Restricted Project

Aug 5 2017

karies created D36368: Fix type printing of array template args.
Aug 5 2017, 5:58 PM · Restricted Project, Restricted Project

Jul 7 2017

karies added a comment to D34985: Do not read the file to determine its name..

@v.g.vassilev will this also benefit from ContentCache::getBuffer improvements from D33275? I guess if getBuffer transparently handles pointing to right buffer we won't need this change?

Jul 7 2017, 8:37 AM

Jul 5 2017

karies added a comment to D34985: Do not read the file to determine its name..

To be clear: emitting annotations will trigger the determination of PresumedLocs. As part of that (but not the first part, IIRC) SourceManager::getBufferName(() will be called which will trigger the fopen of the file, just to get its name. Another task of PresumedLoc is to determine the line number which triggers an fopen; @v.g.vassilev is looking into a possible solution for that one.

Jul 5 2017, 2:34 AM

Jul 3 2017

karies added a comment to D34912: Handle cases where the value is too large to fit into the underlying type..

Two comments:

  • I think the part Val.getBitWidth() == 64 likely needs rewording, although I don't know how
  • I can show the motivation, not sure whether that qualifies as a test case:
Jul 3 2017, 7:33 AM

Jun 22 2017

karies abandoned D34509: Now with test.

I cannot handle Phabricator. Ignore this, Vassil will help on D34444!

Jun 22 2017, 5:20 AM
karies created D34509: Now with test.
Jun 22 2017, 5:18 AM
karies added a child revision for D34444: Teach codegen to work in incremental processing mode.: D34509: Now with test.
Jun 22 2017, 5:18 AM

Jun 21 2017

karies added a comment to D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling.

For the record, here's what GCC does (from https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#C_002b_002b-Dialect-Options which probably has a typo, the second -Wnoexcept is likely meant to be -Wnoexcept-type): "Enabled by -Wabi and -Wc++1z-compat." -Wc++1z-compat is probably meant to enable a group out of which -Wnoexcept-type is just one (currently the only one as far as I can see). FWIW, we notice the missing -Wno-noexcept-type but not -Wc++1z-compat.

Jun 21 2017, 11:23 PM
karies added a comment to D33468: Enable unicode output on terminals..

D34464 fixes this in a less hacky way.

Jun 21 2017, 12:16 PM
karies added a comment to D33468: Enable unicode output on terminals..

Apologies for the slow response.

Jun 21 2017, 2:56 AM

Feb 16 2017

karies added inline comments to D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters.
Feb 16 2017, 11:12 AM
karies added inline comments to D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters.
Feb 16 2017, 12:11 AM

Aug 29 2016

karies added a comment to D21257: Reduce size in memory. This is very helpful in a multi-module setups..

Indeed, this is superseded by Keno's change from DenseMap to std::unordered_map. Sorry for the noise...

Aug 29 2016, 3:05 AM

Jun 15 2016

karies updated subscribers of D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support.
Jun 15 2016, 6:51 AM

May 9 2016

karies added a comment to D17820: Clang Code Completion Filtering .

Regarding the concerns raised by @akyrtzi : maybe it's a question of making the completer interface useful at low cost (with filtering for generic use cases and less ASTReading) versus not breaking existing use cases (fuzzy match). Would you still object to this change if the filtering could be disabled in the CodeCompleteConsumer?

May 9 2016, 2:12 AM

Apr 28 2016

karies updated subscribers of D17820: Clang Code Completion Filtering .
Apr 28 2016, 12:10 PM

Feb 5 2016

karies added reviewers for D16923: [AST] Implemented missing VisitAccessSpecDecl function in ASTImporter class. : klimek, bkramer.

Because of previous review subscriptions...

Feb 5 2016, 6:51 AM

Feb 3 2016

karies closed D16801: [OpenMP] Change in initial size of DSAStackTy::StackTy.

Committed as r259637

Feb 3 2016, 2:50 AM

Dec 14 2015

karies updated subscribers of D12834: add gcc abi_tag support.
Dec 14 2015, 11:26 PM