This is an archive of the discontinued LLVM Phabricator instance.

[LibFuzzer] Fix flakey ``fuzzer-trace-pc.test`` test on OSX
AbandonedPublic

Authored by delcypher on Jun 10 2016, 6:04 PM.

Details

Reviewers
kcc
aizatsky
Summary

[LibFuzzer] Fix flakey `fuzzer-trace-pc.test` test on OSX

When running LLVMFuzzer-FullCoverageSetTest-TracePC the memory limit
is sometimes hit which lead to the test failure.

I'm guessing that much more memory is needed on OSX than Linux because
it takes many more iterations for LibFuzzer to hit BINGO on OSX for this
test. I'm not sure if this is to be expected but given that this test
is relying on program counter values it seems reasonable to expect that
the behaviour between platforms could differ.

Diff Detail

Event Timeline

delcypher updated this revision to Diff 60428.Jun 10 2016, 6:04 PM
delcypher retitled this revision from to [LibFuzzer] Fix flakey ``fuzzer-trace-pc.test`` test on OSX.
delcypher updated this object.
delcypher added reviewers: kcc, aizatsky.
delcypher added subscribers: kcc, aizatsky, zaks.anna and 3 others.
kcc edited edge metadata.Jun 13 2016, 11:55 AM

Something is very much wrong here. Please find what.
The target itself does not allocate any memory.
Of course, libFuzzer does, and there is asan's quarantine so that some memory usage growth is expected
but if it reaches 2Gb something else is bad.

For public observers. @kcc, @zaks.anna and I have discussed this and I'm just going to disable this test on OSX for now so that we can setup an OSX buildbot. @zaks.anna and/or @kubabrecka will look into the issue later on this year.

delcypher abandoned this revision.Jun 13 2016, 5:29 PM