Allow -cl-std and other standard -cl- options from cc1 to driver.
Added a test for the options moved.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
| include/clang/Driver/CC1Options.td | ||
|---|---|---|
| 670 ↗ | (On Diff #59746) | Is this code below to be removed? |
| 671 ↗ | (On Diff #59746) | This isn't part of this change but could we improve the wording a bit for these items: The default is optimizations are enabled -> By default optimizations are enabled |
| 673 ↗ | (On Diff #59746) | This option does nothing and is for compatibility with OpenCL 1.0 -> This option is added for compatibility with OpenCL 1.0. Btw, ideally this option should be deprivcated for CL > 1.0. Could we give diagnostic in this case? |
| 681 ↗ | (On Diff #59746) | Finish with . |
| 683 ↗ | (On Diff #59746) | Finish with . |
| 685 ↗ | (On Diff #59746) | Enable less precise MAD instructions to be generated. -> Allow use of less precise MAD computations in the generated binary. |
Comment Actions
Revised with Anastasia's comments. Please take a look at the diagnostic to see if it is what we want.
| include/clang/Basic/DiagnosticFrontendKinds.td | ||
|---|---|---|
| 220 ↗ | (On Diff #61275) | Looks good. If we could output the current OpenCL version as well to match the diagnostic style from http://reviews.llvm.org/D19780, it would be nice. |
| test/Driver/opencl.cl | ||
| 32 ↗ | (On Diff #61275) | Could you also test the new diagnostic message you are adding please? |
Comment Actions
Revised based on Anastasia's comments. Also clang-test run passes, the testcases should be working correctly.
| lib/Frontend/CompilerInvocation.cpp | ||
|---|---|---|
| 1673 ↗ | (On Diff #61423) | Could you check the OpenCL version here instead? |
| 1675 ↗ | (On Diff #61423) | It seems OK to use Opts.OpenCLVersion directly! |
| test/Driver/opencl.cl | ||
| 1 ↗ | (On Diff #61423) | Since you are not checking anything here, do we even need this RUN line? |
| 20 ↗ | (On Diff #61423) | Could you please separate with an empty line here and order the CHECK lines the same way as RUN lines if possible. It will make it more readable then. Thanks! |
| cfe/trunk/include/clang/Driver/Options.td | ||
|---|---|---|
| 381 | It'd be nice if you added cl-no-signed-zeros since it's mentioned here | |
| cfe/trunk/include/clang/Driver/Options.td | ||
|---|---|---|
| 381 | Can you review http://reviews.llvm.org/D22067 ? Thanks | |