This is an archive of the discontinued LLVM Phabricator instance.

[AVX512] Fix BLENDM lowering patterns.
ClosedPublic

Authored by igorb on Jun 5 2016, 6:35 AM.

Details

Summary

[AVX512] Fix BLENDM lowering patterns. Operands should be swapped to match SELECT behavior.
Use BLENDM instead of masked move instruction.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb updated this revision to Diff 59662.Jun 5 2016, 6:35 AM
igorb retitled this revision from to [AVX512] Fix BLENDM lowering patterns..
igorb updated this object.
igorb added reviewers: delena, AsafBadouh.
igorb set the repository for this revision to rL LLVM.
igorb added a subscriber: llvm-commits.
igorb updated this revision to Diff 60509.Jun 13 2016, 6:24 AM
igorb updated this object.
igorb updated this object.

Looks like many tests were converted to being generated by update_llc_test_checks.py that hadn't used it before resulting in a larger diff and making it difficult to see exactly what changes with this patch. Can you go ahead and re-generate the tests using the script with the current patterns and commit that. Then re-submit this patch relative to that so we can see which tests really change.

igorb updated this revision to Diff 60656.Jun 14 2016, 1:25 AM

Tests re-generated

delena accepted this revision.Jun 14 2016, 1:29 AM
delena edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2016, 1:29 AM
This revision was automatically updated to reflect the committed changes.