This is an archive of the discontinued LLVM Phabricator instance.

[libfuzzer] hiding custom mutator handling in MutationDispatcher.
ClosedPublic

Authored by aizatsky on Jun 3 2016, 11:25 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

aizatsky updated this revision to Diff 59586.Jun 3 2016, 11:25 AM
aizatsky retitled this revision from to [libfuzzer] hiding custom mutator handling in MutationDispatcher..
aizatsky updated this object.
aizatsky added a project: Restricted Project.
aizatsky added a subscriber: llvm-commits.
vitalybuka accepted this revision.Jun 3 2016, 11:31 AM
vitalybuka edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2016, 11:31 AM
kcc added inline comments.Jun 3 2016, 1:47 PM
lib/Fuzzer/FuzzerInternal.h
474 ↗(On Diff #59586)

This works now, but Dan was going to extend this with more weak functions (__sanitizer_*) and EF will be needed in other places of libFuzzer.
Please leave it here.

lib/Fuzzer/FuzzerMutate.cpp
43 ↗(On Diff #59586)

Why not Mutators = DefaultMUtators?
also remove {}

253 ↗(On Diff #59586)

Probably also change LLVMFuzzerMutate to call this one.

aizatsky updated this revision to Diff 59614.Jun 3 2016, 1:52 PM
aizatsky marked 3 inline comments as done.
aizatsky edited edge metadata.

addressing comments

all done.

lib/Fuzzer/FuzzerMutate.cpp
253 ↗(On Diff #59586)

It already calls it.

kcc accepted this revision.Jun 3 2016, 2:29 PM
kcc edited edge metadata.

LGTM with a nit

lib/Fuzzer/FuzzerMutate.cpp
42 ↗(On Diff #59614)

remove these {} too

This revision was automatically updated to reflect the committed changes.