Page MenuHomePhabricator

[Docs][WritingAnLLVMBackend] Makefiles are deprecated
ClosedPublic

Authored by thegameg on May 26 2016, 1:18 PM.

Details

Summary
  • docs/WritingAnLLVMBackend.rst: Makefiles are no longer used. The users should use CMakeLists.txt. In order to add the target, the TARGETS_TO_BUILD is replaced with LLVM_ALL_TARGETS.

Diff Detail

Repository
rL LLVM

Event Timeline

thegameg updated this revision to Diff 58675.May 26 2016, 1:18 PM
thegameg retitled this revision from to [Docs][WritingAnLLVMBackend] Makefiles are deprecated.
thegameg updated this object.
thegameg added reviewers: gribozavr, void, beanz.
thegameg added a subscriber: llvm-commits.
beanz added inline comments.May 26 2016, 1:23 PM
docs/WritingAnLLVMBackend.rst
163 ↗(On Diff #58675)

You actually don't want to modify LLVM_ALL_TARGETS. Instead you want to configure with "-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=Dummy". That will build the dummy target without needing to add it to "All" and we generally don't encourage adding a target to "All" until after it is stable.

thegameg updated this revision to Diff 58688.May 26 2016, 1:39 PM

Prefer using LLVM_EXPERIMENTAL_TARGETS_TO_BUILD instead of adding it directly to LLVM_ALL_TARGETS.

beanz accepted this revision.May 26 2016, 1:39 PM
beanz edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 26 2016, 1:39 PM
thegameg marked an inline comment as done.May 26 2016, 1:41 PM

Can you commit this for me @beanz? I don't have commit access. Thanks!

This revision was automatically updated to reflect the committed changes.