This is an archive of the discontinued LLVM Phabricator instance.

Differential D20552

AMDGPU: Allow clustering flat memory operations
ClosedPublic

Authored by arsenm on May 23 2016, 8:46 PM.

Details

Reviewers
• tstellarAMD

Diff Detail

Event Timeline

arsenm updated this revision to Diff 58184.May 23 2016, 8:46 PM
arsenm retitled this revision from to AMDGPU: Allow clustering flat memory operations.
arsenm updated this object.
arsenm added a reviewer: • tstellarAMD.
arsenm added a subscriber: llvm-commits.
Herald added subscribers: kzhuravl, arsenm. · View Herald TranscriptMay 23 2016, 8:46 PM
arsenm added a parent revision: D20546: AMDGPU: Handle flat in getMemOpBaseRegImmOfs.May 23 2016, 8:46 PM
arsenm added a parent revision: D20633: AMDGPU: Rename flat operands to match mubuf.May 25 2016, 10:34 AM
• tstellarAMD edited edge metadata.Jun 14 2016, 6:11 PM

Are there tests for this?

arsenm added a comment.Jan 23 2017, 3:25 PM
In D20552#458308, @tstellarAMD wrote:

Are there tests for this?

I don't think this does much because there is no offset. It seems like a flaw in the scheduler/this hook that it will only schedule based on the immediate offset in the instruction and not based on the offset in the mem operand

• tstellarAMD accepted this revision.Feb 1 2017, 10:59 AM
This revision is now accepted and ready to land.Feb 1 2017, 10:59 AM
arsenm closed this revision.Feb 1 2017, 12:34 PM

r293809

Revision Contents

PathSize
lib/
Target/
AMDGPU/
3 lines

Diff 58184

lib/Target/AMDGPU/SIInstrInfo.cpp

Show First 20 Lines • Show All 298 Lines • ▼ Show 20 Lines
bool SIInstrInfo::shouldClusterMemOps(MachineInstr *FirstLdSt, bool SIInstrInfo::shouldClusterMemOps(MachineInstr *FirstLdSt,
MachineInstr *SecondLdSt, MachineInstr *SecondLdSt,
unsigned NumLoads) const { unsigned NumLoads) const {
const MachineOperand *FirstDst = nullptr; const MachineOperand *FirstDst = nullptr;
const MachineOperand *SecondDst = nullptr; const MachineOperand *SecondDst = nullptr;
if ((isMUBUF(*FirstLdSt) && isMUBUF(*SecondLdSt)) || if ((isMUBUF(*FirstLdSt) && isMUBUF(*SecondLdSt)) ||
(isMTBUF(*FirstLdSt) && isMTBUF(*SecondLdSt))) { (isMTBUF(*FirstLdSt) && isMTBUF(*SecondLdSt)) ||
(isFLAT(*FirstLdSt) && isFLAT(*SecondLdSt))) {
FirstDst = getNamedOperand(*FirstLdSt, AMDGPU::OpName::vdata); FirstDst = getNamedOperand(*FirstLdSt, AMDGPU::OpName::vdata);
SecondDst = getNamedOperand(*SecondLdSt, AMDGPU::OpName::vdata); SecondDst = getNamedOperand(*SecondLdSt, AMDGPU::OpName::vdata);
} else if (isSMRD(*FirstLdSt) && isSMRD(*SecondLdSt)) { } else if (isSMRD(*FirstLdSt) && isSMRD(*SecondLdSt)) {
FirstDst = getNamedOperand(*FirstLdSt, AMDGPU::OpName::sdst); FirstDst = getNamedOperand(*FirstLdSt, AMDGPU::OpName::sdst);
SecondDst = getNamedOperand(*SecondLdSt, AMDGPU::OpName::sdst); SecondDst = getNamedOperand(*SecondLdSt, AMDGPU::OpName::sdst);
} else if (isDS(*FirstLdSt) && isDS(*SecondLdSt)) { } else if (isDS(*FirstLdSt) && isDS(*SecondLdSt)) {
FirstDst = getNamedOperand(*FirstLdSt, AMDGPU::OpName::vdst); FirstDst = getNamedOperand(*FirstLdSt, AMDGPU::OpName::vdst);
SecondDst = getNamedOperand(*SecondLdSt, AMDGPU::OpName::vdst); SecondDst = getNamedOperand(*SecondLdSt, AMDGPU::OpName::vdst);
▲ Show 20 Lines • Show All 2,824 Lines • Show Last 20 Lines