This is an archive of the discontinued LLVM Phabricator instance.

Proposal for using stricter error checking in SampleProf
AcceptedPublic

Authored by vsk on May 23 2016, 11:08 AM.

Details

Summary

I'd like to change how error handling is done in the SampleProf code to use the new Error/Expected classes. This will bring make it more consistent with the rest of lib/ProfileData, and will make the code easier to debug and maintain.

My plan is to 1) introduce a soft error tracking class (c.f D20082), 2) start handling any errors we might be dropping now, and finally 3) make the switch from std::error_code to llvm::Error.

Does that plan sound good?

Diff Detail

Event Timeline

vsk updated this revision to Diff 58115.May 23 2016, 11:08 AM
vsk retitled this revision from to Proposal for using stricter error checking in SampleProf.
vsk updated this object.
vsk added reviewers: dnovillo, danielcdh.
vsk added a subscriber: llvm-commits.
dnovillo accepted this revision.May 24 2016, 7:38 AM
dnovillo edited edge metadata.

Sounds like a great plan. Thanks for doing this!

LGTM.

This revision is now accepted and ready to land.May 24 2016, 7:38 AM

Looks like patch was not committed.