Page MenuHomePhabricator

CodeGen: Move the call to DwarfDebug::beginModule() out of the constructor.
ClosedPublic

Authored by pcc on May 18 2016, 10:40 PM.

Details

Summary

This gives AsmPrinter a chance to initialize its DD field before
we call beginModule(), which is about to start using it.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 57735.May 18 2016, 10:40 PM
pcc retitled this revision from to CodeGen: Move the call to DwarfDebug::beginModule() out of the constructor..
pcc updated this object.
pcc added reviewers: aprantl, dexonsmith, dblaikie.
pcc added a subscriber: llvm-commits.
aprantl accepted this revision.May 20 2016, 9:11 AM
aprantl edited edge metadata.

I wanted to suggest a change in the doxygen comment to DwarfDebug::beginModule() to indicate that this is now supposed to be called from the outside, but it looks like the existing comment describes the new usage pattern better than the current one :-)
LGTM.

This revision is now accepted and ready to land.May 20 2016, 9:11 AM
This revision was automatically updated to reflect the committed changes.