Page MenuHomePhabricator

CodeGen: Do not require a MachineFunction just to create a DIEDwarfExpression.
ClosedPublic

Authored by pcc on May 18 2016, 10:40 PM.

Details

Summary

We are about to start using DIEDwarfExpression to create global variable
DIEs, which happens before we generate code for functions.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc updated this revision to Diff 57734.May 18 2016, 10:40 PM
pcc retitled this revision from to CodeGen: Do not require a MachineFunction just to create a DIEDwarfExpression..
pcc updated this object.
pcc added reviewers: aprantl, dexonsmith, dblaikie.
pcc added a subscriber: llvm-commits.
aprantl accepted this revision.May 20 2016, 9:02 AM
aprantl edited edge metadata.

I was briefly debating with myself whether it makes sense to subclass DIEDwarfExpression again for Expressions that are based off MachineRegs, but I think this is fine as well.

LGTM, thanks!

This revision is now accepted and ready to land.May 20 2016, 9:02 AM
This revision was automatically updated to reflect the committed changes.