This is an archive of the discontinued LLVM Phabricator instance.

Remove specializations of ProfileSummary (InstrProfSummary and SampleProfileSummary)
ClosedPublic

Authored by eraman on May 18 2016, 3:08 PM.

Details

Summary

This removes the subclasses of ProfileSummary, moves the members of the derived classes to the base class.

Diff Detail

Event Timeline

eraman updated this revision to Diff 57684.May 18 2016, 3:08 PM
eraman retitled this revision from to Remove specializations of ProfileSummary (InstrProfSummary and SampleProfileSummary).
eraman updated this object.
eraman added reviewers: silvas, vsk.
eraman added a parent revision: D20314: Move ProfileSummary to IR.
eraman added subscribers: davidxl, llvm-commits.
silvas accepted this revision.May 18 2016, 6:39 PM
silvas edited edge metadata.

LGTM

include/llvm/IR/ProfileSummary.h
77

As more passes start using these methods, you may want to add some documentation to them or rename them to be more clear.

This revision is now accepted and ready to land.May 18 2016, 6:39 PM
eraman added inline comments.May 19 2016, 2:10 PM
include/llvm/IR/ProfileSummary.h
77

I'm struggling to come up with better names - your suggestions are welcome. In any case, the plan is to provide an immutable analysis pass that will consume the profile summary and provide APIs like "isHotCount" for the optimization passes to use.

This revision was automatically updated to reflect the committed changes.