This is an archive of the discontinued LLVM Phabricator instance.

pcc retitled this revision from ELF: Use canOmitFromDynSym() to control which symbols may be omitted from the symbol table. to ELF: Add a test showing that the new local_unnamed_addr attribute can permit internalization..May 17 2016, 3:06 PM

pcc updated this object.

pcc added a parent revision: D20260: IR: Introduce local_unnamed_addr attribute..

LGTM once the dependencies are in.

This revision is now accepted and ready to land.May 17 2016, 3:24 PM

Closed by commit rL272711: ELF: Add a test showing that the new local_unnamed_addr attribute can permit… (authored by pcc). · Explain WhyJun 14 2016, 2:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

ELF/

InputFiles.cpp

2 lines

test/

ELF/

lto/

internalize-exportdyn.ll

2 lines

Diff 57255

ELF/InputFiles.cpp

Show First 20 Lines • Show All 562 Lines • ▼ Show 20 Lines	Symbol BitcodeFile::createSymbol(const DenseSet<const Comdat > &KeptComdats,
uint32_t Binding = IsWeak ? STB_WEAK : STB_GLOBAL;		uint32_t Binding = IsWeak ? STB_WEAK : STB_GLOBAL;

uint8_t Type = STT_NOTYPE;		uint8_t Type = STT_NOTYPE;
bool CanOmitFromDynSym = false;		bool CanOmitFromDynSym = false;
// FIXME: Expose a thread-local flag for module asm symbols.		// FIXME: Expose a thread-local flag for module asm symbols.
if (GV) {		if (GV) {
if (GV->isThreadLocal())		if (GV->isThreadLocal())
Type = STT_TLS;		Type = STT_TLS;
CanOmitFromDynSym = canBeOmittedFromSymbolTable(GV);		CanOmitFromDynSym = GV->canOmitFromDynSym();
}		}

uint8_t Visibility;		uint8_t Visibility;
if (GV)		if (GV)
Visibility = getGvVisibility(GV);		Visibility = getGvVisibility(GV);
else		else
// FIXME: Set SF_Hidden flag correctly for module asm symbols, and expose		// FIXME: Set SF_Hidden flag correctly for module asm symbols, and expose
// protected visibility.		// protected visibility.
▲ Show 20 Lines • Show All 205 Lines • Show Last 20 Lines

test/ELF/lto/internalize-exportdyn.ll

	Show All 13 Lines
	define void @foo() {			define void @foo() {
	ret void			ret void
	}			}

	define hidden void @bar() {			define hidden void @bar() {
	ret void			ret void
	}			}

	define linkonce_odr void @zed() unnamed_addr {			define linkonce_odr void @zed() can_omit_from_dynsym {
	ret void			ret void
	}			}

	define linkonce_odr void @bah() {			define linkonce_odr void @bah() {
	ret void			ret void
	}			}

	define linkonce_odr void @baz() {			define linkonce_odr void @baz() {
	Show All 12 Lines

This is an archive of the discontinued LLVM Phabricator instance.

ELF: Add a test showing that the new local_unnamed_addr attribute can permit internalization.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 57255

ELF/InputFiles.cpp

test/ELF/lto/internalize-exportdyn.ll

ELF: Add a test showing that the new local_unnamed_addr attribute can permit internalization.
ClosedPublic