This is an archive of the discontinued LLVM Phabricator instance.

Differential D20101

[Clang][AVX512] completing missing intrinsics [pandnd].
ClosedPublic

Authored by m_zuckerman on May 10 2016, 6:42 AM.

Details

Reviewers
AsafBadouh
delena
igorb
Commits
rG2cacc35343e1: [Clang][AVX512] completing missing intrinsics [pandnd].
rC269939: [Clang][AVX512] completing missing intrinsics [pandnd].
rL269939: [Clang][AVX512] completing missing intrinsics [pandnd].

Diff Detail

Event Timeline

m_zuckerman updated this revision to Diff 56708.May 10 2016, 6:42 AM
m_zuckerman retitled this revision from to [Clang][AVX512] completing missing intrinsics [pandnd]..
m_zuckerman updated this object.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: llvm-commits.
AsafBadouh added inline comments.May 18 2016, 12:39 AM
lib/Headers/avx512fintrin.h
402

I think it will be better to use:

return (__m512i)(~(__v8di)__A & (__v8di)__B);
m_zuckerman updated this revision to Diff 57598.May 18 2016, 5:22 AM
AsafBadouh accepted this revision.May 18 2016, 6:34 AM
AsafBadouh edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 18 2016, 6:34 AM
Closed by commit rL269939: [Clang][AVX512] completing missing intrinsics [pandnd]. (authored by mzuckerm). · Explain WhyMay 18 2016, 8:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Headers/
avx512fintrin.h
avx512fintrin.h (revision 268028)
6 lines
test/
CodeGen/
avx512f-builtins.c
avx512f-builtins.c (revision 268028)
8 lines

Diff 57598

lib/Headers/avx512fintrin.h

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 387 Lines • ▼ Show 20 Lines_mm512_maskz_and_epi64(__mmask8 __k, __m512i __a, __m512i __b)
return (__m512i) __builtin_ia32_pandq512_mask ((__v8di) __a, return (__m512i) __builtin_ia32_pandq512_mask ((__v8di) __a,
(__v8di) __b, (__v8di) __b,
(__v8di) (__v8di)
_mm512_setzero_si512 (), _mm512_setzero_si512 (),
(__mmask8) __k); (__mmask8) __k);
} }
static __inline__ __m512i __DEFAULT_FN_ATTRS static __inline__ __m512i __DEFAULT_FN_ATTRS
_mm512_andnot_si512 (__m512i __A, __m512i __B)
{
return (__m512i)(~(__A) & __B);
}
static __inline__ __m512i __DEFAULT_FN_ATTRS
_mm512_andnot_epi32 (__m512i __A, __m512i __B) _mm512_andnot_epi32 (__m512i __A, __m512i __B)
AsafBadouhUnsubmitted
Not Done
ReplyInline Actions

I think it will be better to use:

return (__m512i)(~(__v8di)__A & (__v8di)__B);
AsafBadouh: I think it will be better to use: ``` return (__m512i)(~(__v8di)__A & (__v8di)__B); ```
{ {
return (__m512i) __builtin_ia32_pandnd512_mask ((__v16si) __A, return (__m512i) __builtin_ia32_pandnd512_mask ((__v16si) __A,
(__v16si) __B, (__v16si) __B,
(__v16si) (__v16si)
_mm512_setzero_si512 (), _mm512_setzero_si512 (),
(__mmask16) -1); (__mmask16) -1);
} }
▲ Show 20 Lines • Show All 7,282 Lines • Show Last 20 Lines

test/CodeGen/avx512f-builtins.c

Show First 20 Lines • Show All 1,252 Lines • ▼ Show 20 Lines
__m512i test_mm512_mask_andnot_epi32 (__mmask16 __k,__m512i __A, __m512i __B, __m512i test_mm512_mask_andnot_epi32 (__mmask16 __k,__m512i __A, __m512i __B,
__m512i __src) { __m512i __src) {
//CHECK-LABEL: @test_mm512_mask_andnot_epi32 //CHECK-LABEL: @test_mm512_mask_andnot_epi32
//CHECK: @llvm.x86.avx512.mask.pandn.d.512 //CHECK: @llvm.x86.avx512.mask.pandn.d.512
return _mm512_mask_andnot_epi32(__src,__k,__A,__B); return _mm512_mask_andnot_epi32(__src,__k,__A,__B);
} }
__m512i test_mm512_andnot_si512(__m512i __A, __m512i __B)
{
//CHECK-LABLE: @test_mm512_andnot_si512
//CHECK: %neg.i = xor <8 x i64> %__A, <i64 -1, i64 -1, i64 -1, i64 -1, i64 -1, i64 -1, i64 -1, i64 -1>
//CHECK: %and.i = and <8 x i64> %__B, %neg.i
return _mm512_andnot_si512(__A, __B);
}
__m512i test_mm512_andnot_epi32(__m512i __A, __m512i __B) { __m512i test_mm512_andnot_epi32(__m512i __A, __m512i __B) {
//CHECK-LABEL: @test_mm512_andnot_epi32 //CHECK-LABEL: @test_mm512_andnot_epi32
//CHECK: @llvm.x86.avx512.mask.pandn.d.512 //CHECK: @llvm.x86.avx512.mask.pandn.d.512
return _mm512_andnot_epi32(__A,__B); return _mm512_andnot_epi32(__A,__B);
} }
__m512i test_mm512_maskz_andnot_epi64 (__mmask8 __k,__m512i __A, __m512i __B) { __m512i test_mm512_maskz_andnot_epi64 (__mmask8 __k,__m512i __A, __m512i __B) {
//CHECK-LABEL: @test_mm512_maskz_andnot_epi64 //CHECK-LABEL: @test_mm512_maskz_andnot_epi64
▲ Show 20 Lines • Show All 4,067 Lines • Show Last 20 Lines