Page MenuHomePhabricator

[include-fixer] Add basic documentation.
ClosedPublic

Authored by bkramer on May 10 2016, 3:26 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

bkramer updated this revision to Diff 56684.May 10 2016, 3:26 AM
bkramer retitled this revision from to [include-fixer] Add basic documentation..
bkramer updated this object.
bkramer added reviewers: hokein, djasper, klimek.
bkramer added a subscriber: cfe-commits.
bkramer updated this revision to Diff 56687.May 10 2016, 3:35 AM

de-freud

hokein added inline comments.May 10 2016, 8:58 AM
docs/include-fixer.rst
36 ↗(On Diff #56687)

A extra space before a.

48 ↗(On Diff #56687)

We should also create a link to compile_commands.json in path/to/llvm/source/.

bkramer updated this revision to Diff 56856.May 11 2016, 1:02 AM

Address review comments.

bkramer marked 2 inline comments as done.May 11 2016, 1:02 AM
bkramer added inline comments.
docs/include-fixer.rst
48 ↗(On Diff #56687)

If the user followed the instructions at http://clang.llvm.org/docs/HowToSetupToolingForLLVM.html the link will be there already. I'll add it here with a clarifying comment.

klimek accepted this revision.May 11 2016, 2:32 AM
klimek edited edge metadata.

lg

docs/include-fixer.rst
16 ↗(On Diff #56684)

s/, b/. B/

This revision is now accepted and ready to land.May 11 2016, 2:32 AM
This revision was automatically updated to reflect the committed changes.