Symbol streams and type streams have the same format, and it's possible we might find other types of "things" that have similar formats as well. So rather than reproduce the code, we templatize TypeIterator on the type enumeration kind, and allow it to iterate over arbitrary streams of similarly laid out records.
|20 ↗||(On Diff #56477)|
Maybe call the template parameter RecordKind or KindType so you can call the Record field Kind instead of Type?
|113–114 ↗||(On Diff #56477)|
// end namespace codeview / llvm?
|275 ↗||(On Diff #56477)|
Once upon a type, TypeRecord was an actual class. With TypeRecordPrefix gone, the last vestiges of it are gone. Can you replace TypeRecord with "type record" here?
I just noticed this problem on powerpc as well:
In file included from /home/seurer/llvm/llvm-test/include/llvm/DebugInfo/CodeView/SymbolRecord.h:14:0,
/home/seurer/llvm/llvm-test/include/llvm/DebugInfo/CodeView/RecordIterator.h:15:33: fatal error: llvm/support/Endian.h: No such file or directory
seurer@makalu-lp1:~/llvm/build/llvm-test$ find $LLVM_SRC -name Endian.h
Note "support" (incorrect) versus "Support" (correct).