Enable tests on the Windows LLDB buildbot

[zturner]

Summary

Is this all that is necessary to get this working? ninja check-lldb doesn't use lit but a different testing system, so I don't know if special logic is needed to get buildbot to understand the output of check-lldb, or if it will just work.

Also, how do I add myself to the email list so I get notified whenever this buildbot fails, even if it didn't fail because of me?

[gkistanova]

LGTM.

Is this all that is necessary to get this working?

This should be enough to get it working in general. Depending on the degree of understanding you are after, you might need to implement a custom parser for the tests output, but having just this looks like a good start. ninja check-lldb doesn't use lit but a different testing system, so I don't know if special logic is needed to get buildbot to understand the output of check-lldb, or if it will just work.

Also, how do I add myself to the email list so I get notified whenever this buildbot fails, even if it didn't fail because of me?

You can add MailNotifier to status.py for this.

Thanks

Galina

[zturner]

I had to revert this for now as I work through a couple of issues. Is
there any way to get the FULL PATH of the build directory on the slave?
Right now I'm specifying -DLLDB_TEST_COMPILER="bin\clang.exe", but I need
this to be the full path, not a relative path.

[gkistanova]

Sure. You can do something like

1. Determine the build directory. f.addStep(SetProperty(name="get_builddir", command=["pwd"], property="builddir", description="set build dir", workdir="."))

and then use it with WithProperties similar to this:

-DLLDB_TEST_COMPILER=WithProperties('%(builddir)s/<whetver-path-from-there>/bin/clang.exe')

There is a usage example in getLLDBBuildFactory in LLDBBuilder.py.

[zturner]

By the way, with r269342 I ttried to disable tests and enable checking out
and building LLD. But for some reason, neither change seems to have been
picked up by the buildbot yet. When I enabled tests, it seemed to take
effect almost immediately, so I'm wondering if I'm missing something or if
it will take some time?

[gkistanova]

The changes pick up after master updates.
I will update the master tonight.

Thanks

Galina

[Eugene.Zelenko]

Committed in r269306.

buildbot/osuosl/master/config/builders.py

         {'name': "lldb-x86-windows-msvc2015",
          'slavenames': ["zturner-win2008"],
          'builddir': "lldb-windows-x86",
-         'factory': LLDBBuilder.getLLDBWindowsCMakeBuildFactory()},
+         'factory': LLDBBuilder.getLLDBWindowsCMakeBuildFactory(test=True)},
         {'name': "lldb-x86-win7-msvc",
          'slavenames': ["hexagon-build-01"],
          'builddir': "builddir/lldb-win7-msvc",