Page MenuHomePhabricator

Move createReversePostOrderFunctionAttrsPass right after the inliner is done
ClosedPublic

Authored by mehdi_amini on May 2 2016, 9:14 AM.

Details

Summary

This is where it was originally, until LoopVersioningLICM was
inserted before in r259986, I don't believe it was on purpose.

Diff Detail

Event Timeline

mehdi_amini updated this revision to Diff 55831.May 2 2016, 9:14 AM
mehdi_amini retitled this revision from to Move createReversePostOrderFunctionAttrsPass right after the inliner is done.
mehdi_amini updated this object.
mehdi_amini added subscribers: bogner, llvm-commits.
chandlerc accepted this revision.May 2 2016, 9:38 AM
chandlerc edited edge metadata.

This was clearly a mistake. We have tests for this that you can probable just add some CHECK lines too to get coverage. See test/Other/pass-pipelines.ll

This revision is now accepted and ready to land.May 2 2016, 9:38 AM
ashutosh.nema edited edge metadata.May 2 2016, 9:35 PM

Thanks for pointing Mehdi, this change looks OK.

mehdi_amini closed this revision.May 3 2016, 8:32 AM