Mostly looks OK, just few minor comment.

This patch looks OK to me, except the floating point value support in NV (maybe it can be done as a later enhancement once NV supports floating point values)

Thanks for working on this !

This patch is little old and not updated with latest vectorization changes.

Sorry for the late reply, I was on vacation.

Is store is always 2 UOps on x86, independent of the type and register(xmm/ymm) ?

Thanks Balaram for posting this patch, in general idea looks good to preserve the canonical form of the loops.

Block layout description

This change includes:

Test cases are missing well add.

Block layout:

LGTM, thanks!

It’s good to avoid loop which are not in loop-simplify form.

LGTM.

Changes looks OK, except one minor formatting comment.

Thanks Evgeny for working on this.

Thanks Ayal for looking into this RFC.

Thanks Elena for looking into this RFC.

Adding Shahid as co Author.

LGTM.

Thanks for pointing Mehdi, this change looks OK.

Thanks Simon for review, this change landed at revision 267123.

Incorporated comments from Simon.

Indentation is still not as per llvm coding standard, please run clang-format.
You can specifically run it on the code added by you using below command:

I see lot of indentation problems here, please correct them.
Try using clang-format its useful.

Thanks Vaivaswatha, looks OK to me except the name of function.
As I mentioned earlier ‘cloneInnermostLoopWithPreheader’ looks more intuitive
vs ‘cloneInnerLoopWithPreheader’ because we clone the innermost loop only.

Thanks Sanjay for working on this.

Thanks Renato for working on this.

Thanks Nick, I will incorporate your comments.

Thanks Hal.

Corrected include file order.

Addressed Hal's comments.

Thanks Hal for clarification, will make these changes and come back.

Thanks Hal.

Hi Hal,

Addressed Hal's & Adam's comments.

Addressed Hal's comment.

Hi Hal,

Hi Tobias,

Hi Hal,

Thanks Hal, for again looking into this change.

Ping.

Hi Hal,

Incorporated Hal comments & updated LangRef.

This patch does not contain LangRef changes, I'll soon submitting it.

Incorporated review comments from Hal.

Hal, is below comments on call handling looks OK to you ?

Thanks Hal for review.

Thanks Hal for looking into this again.

Ping.

Incorporated review comments.

Thanks Charlie, I will correct these.

Ping.

Does this patch look OK to you now ?

r244763

LoopVersioning utility now calls ‘addPHINodes’ implicitly(r245579).
Updated LoopVersioningLICM to consider this change.

Revision: 245416

1. LoopVersioning utility is now available, so LoopVersioningLICM is using that utility.

Thanks Adam, will incorporate these comments and check-in.

Thanks Adam.

Incorporated comments from Adam.

Incorporated comments from Adam.

Incorporated comments from Adam.

Sure Adam, will update it.

Thanks Hal.

Incorporated comments from Hal.

Incorporated comments from Hal.

Hi Hal,

Does this looks OK to you ?

Yes, LGTM (with one small change in a comment requested below).

Incorporated comments from Hal.

Ping.

Thanks Adam, This looks OK to me.

Incorporated comments from Hal.

Thanks Hal.
I'll incorporate these comments and soon come up with a new patch.

Typo:

• Loop versioning need these to set meta data.

Its
+ Loop versioning LICM need these to set meta data.