Page MenuHomePhabricator

[Polly] cmake: Set LINK_POLLY_INTO_TOOLS to ON
ClosedPublic

Authored by grosser on Apr 29 2016, 1:04 AM.

Details

Summary

With Polly checked into LLVM it was since a long time possible to compile
clang/opt/bugpoint with Polly support directly linked in, instead of only
providing Polly as a separate loadable module. This commit switches the
default from providing Polly as a module to linking Polly into tools, such
that it becomes unnecessary to load the Polly module when playing with Polly.
Such configuration has shown a lot more convenient for day-to-day Polly use.

This change does not impact the default behavior of any tool, if Polly is not
explicitly enabled when calling clang/opt/bugpoint Polly does not affect
compilation.

This change also does not impact normal LLVM/clang checkouts that do not
contain Polly.

Diff Detail

Repository
rL LLVM

Event Timeline

grosser updated this revision to Diff 55540.Apr 29 2016, 1:04 AM
grosser retitled this revision from to [Polly] cmake: Set LINK_POLLY_INTO_TOOLS to ON.
grosser updated this object.
grosser added subscribers: llvm-commits, pollydev.

I link Polly into my tools anyway, thus I'm in favor of changing the
default.

grosser created this revision.
grosser added reviewers: jdoerfert, Meinersbur, sebpop, etherzhhb, zinob, hiraditya.
grosser added subscribers: llvm-commits, pollydev.

With Polly checked into LLVM it was since a long time possible to compile
clang/opt/bugpoint with Polly support directly linked in, instead of only
providing Polly as a separate loadable module. This commit switches the
default from providing Polly as a module to linking Polly into tools, such
that it becomes unnecessary to load the Polly module when playing with Polly.
Such configuration has shown a lot more convenient for day-to-day Polly use.

This change does not impact the default behavior of any tool, if Polly is not
explicitly enabled when calling clang/opt/bugpoint Polly does not affect
compilation.

This change also does not impact normal LLVM/clang checkouts that do not
contain Polly.

http://reviews.llvm.org/D19711

Files:

CMakeLists.txt

Index: CMakeLists.txt
===================================================================

    • CMakeLists.txt +++ CMakeLists.txt @@ -327,7 +327,7 @@ "Use -gsplit-dwarf when compiling llvm." OFF)

      option(WITH_POLLY "Build LLVM with Polly" ON) -option(LINK_POLLY_INTO_TOOLS "Static link Polly into tools" OFF) +option(LINK_POLLY_INTO_TOOLS "Static link Polly into tools" ON)
  1. Define an option controlling whether we should build for 32-bit on 64-bit
  2. platforms, where supported.

Index: CMakeLists.txt
===================================================================

    • CMakeLists.txt +++ CMakeLists.txt @@ -327,7 +327,7 @@ "Use -gsplit-dwarf when compiling llvm." OFF)

      option(WITH_POLLY "Build LLVM with Polly" ON) -option(LINK_POLLY_INTO_TOOLS "Static link Polly into tools" OFF) +option(LINK_POLLY_INTO_TOOLS "Static link Polly into tools" ON)
  1. Define an option controlling whether we should build for 32-bit on 64-bit
  2. platforms, where supported.
Meinersbur edited edge metadata.Apr 29 2016, 5:13 AM

I also have LINK_POLLY_INTO_TOOLS enabled in my configurations. The -load mechanism doesn't even exist on Windows.

This revision was automatically updated to reflect the committed changes.