As these are really testing separate issues, they should be run as separate
tests.
Details
- Reviewers
zturner clayborg granata.enrico - Commits
- rG3cf8e16f44a4: Split out console and file writing cases in TestCommandScriptImmediateOutput
rLLDB268397: Split out console and file writing cases in TestCommandScriptImmediateOutput
rL268397: Split out console and file writing cases in TestCommandScriptImmediateOutput
Diff Detail
Event Timeline
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py | ||
---|---|---|
29 | Can we raise this a little bit? I worry that going all the way from 60 down to 5 might cause this test to start failing more in load scenarios. Maybe 10 would be a better value? | |
43 | Feel free to make the file version non pexpect-based if you want |
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py | ||
---|---|---|
29 | I chose 5 because your original console unit test used 5. I changed it to 60 when I added the file aspects. I don't have a problem changing it to 10 though | |
43 | I ended up finding clayborg's sendline bug-fix, so pexpect should be fine (actually probably preferred) |
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py | ||
---|---|---|
29 | 10 is probably fine - the file version also seems to use 10, so I'd just make them consistent. Other than that LGTM. |
Can we raise this a little bit? I worry that going all the way from 60 down to 5 might cause this test to start failing more in load scenarios. Maybe 10 would be a better value?