[scan-build] fix logic error warning emitted on compiler-rt code base

[apelete]

Summary

Fix a "called c++ object pointer is null" warning emitted by Clang
Static Analyzer on the following file:

• lib/asan/asan_suppressions.cc.

Signed-off-by: Apelete Seketeli <[e-mail]>

[Eugene.Zelenko]

lib/asan/asan_suppressions.cc

21

Please use cassert for C++ code. See http://clang.llvm.org/extra/clang-tidy/checks/modernize-deprecated-headers.html.

[apelete]

[scan-build] fix logic error warning emitted on compiler-rt code base

Changes since last revision:

• replace deprecated <assert.h> library by C++ <cassert> equivalent.

[apelete]

lib/asan/asan_suppressions.cc

21

If the changes are good for you, could you please check this in the main repository for me ?

Thanks for your review.

[kcc]

This code does not use *any* system headers. You may use CHECK

[apelete]

[scan-build] fix logic error warning emitted on compiler-rt code base

Changes since last revision:

• Replace assert() with CHECK() since the code do not rely on any system header.

[kcc]

LGTM

[apelete]

In D19627#417229, @kcc wrote:

LGTM

Could you please check this in the main repository for me ?

Thanks.

lib/asan/asan_suppressions.cc

 //===----------------------------------------------------------------------===//
 
 #include "asan_suppressions.h"
 
 #include "asan_stack.h"
 #include "sanitizer_common/sanitizer_placement_new.h"
 #include "sanitizer_common/sanitizer_suppressions.h"
 #include "sanitizer_common/sanitizer_symbolizer.h"
+#include <assert.h>
 
 namespace __asan {
 
 ALIGNED(64) static char suppression_placeholder[sizeof(SuppressionContext)];
 static SuppressionContext *suppression_ctx = nullptr;
 static const char kInterceptorName[] = "interceptor_name";
 static const char kInterceptorViaFunction[] = "interceptor_via_fun";
 static const char kInterceptorViaLibrary[] = "interceptor_via_lib";
if (suppression_ctx->HasSuppressionType(kInterceptorViaLibrary)) {
       // Match "interceptor_via_lib" suppressions.
       if (const char *module_name = symbolizer->GetModuleNameForPc(addr))
         if (suppression_ctx->Match(module_name, kInterceptorViaLibrary, &s))
           return true;
     }
 
     if (suppression_ctx->HasSuppressionType(kInterceptorViaFunction)) {
       SymbolizedStack *frames = symbolizer->SymbolizePC(addr);
+      assert(frames && "does not point to any symbolized frames");
       for (SymbolizedStack *cur = frames; cur; cur = cur->next) {
         const char *function_name = cur->info.function;
         if (!function_name) {
           continue;
         }
         // Match "interceptor_via_fun" suppressions.
         if (suppression_ctx->Match(function_name, kInterceptorViaFunction,
                                    &s)) {