LoadStoreVectorizer: Skip optnone functions

[arsenm]

Use skipFunction

[jlebar]

test/Transforms/LoadStoreVectorizer/AMDGPU/optnone.ll

12

Nit, If you're paranoid, consider having a test right here that ensures that a non-optnone function with the same body gets vectorized. You never know. :)

[arsenm]

r274296

[MatzeB]

lib/Transforms/Vectorize/LoadStoreVectorizer.cpp

158

I would recommend to make skipFunction() the first thing in runOnFunction(). Otherwise I am not sure about the effects on opt bisection when the number of calls to skipFunction() depends on the number of NoImplicitFloat attributes in the IR...

lib/Transforms/Vectorize/LoadStoreVectorizer.cpp

 bool LoadStoreVectorizer::runOnFunction(Function &F) {
   AliasAnalysis &AA = getAnalysis<AAResultsWrapperPass>().getAAResults();
   DominatorTree &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
   ScalarEvolution &SE = getAnalysis<ScalarEvolutionWrapperPass>().getSE();
   TargetTransformInfo &TTI
     = getAnalysis<TargetTransformInfoWrapperPass>().getTTI(F);
 
   // Don't vectorize when the attribute NoImplicitFloat is used.
-  if (F.hasFnAttribute(Attribute::NoImplicitFloat))
+  if (F.hasFnAttribute(Attribute::NoImplicitFloat) || skipFunction(F))
     return false;
 
   Vectorizer V(F, AA, DT, SE, TTI);
   return V.run();
 }
 
 // Vectorizer Implementation
 bool Vectorizer::run() {

test/Transforms/LoadStoreVectorizer/AMDGPU/optnone.ll

+; RUN: opt -mtriple=amdgcn-amd-amdhsa -load-store-vectorizer -S -o - %s | FileCheck %s
+
+; CHECK-LABEL: @optnone(
+; CHECK: store i32
+; CHECK: store i32
+define void @optnone(i32 addrspace(1)* %out) noinline optnone {
+  %out.gep.1 = getelementptr i32, i32 addrspace(1)* %out, i32 1
+
+  store i32 123, i32 addrspace(1)* %out.gep.1
+  store i32 456, i32 addrspace(1)* %out
+  ret void
+}