Page MenuHomePhabricator

[ELF] - Implemented linkerscript ALIGN command
ClosedPublic

Authored by grimar on Apr 21 2016, 7:00 AM.

Diff Detail

Event Timeline

grimar updated this revision to Diff 54496.Apr 21 2016, 7:00 AM
grimar retitled this revision from to [ELF] - Implemented linkerscript ALIGN command.
grimar updated this object.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar.
grimar added a subscriber: emaste.Apr 21 2016, 7:02 AM
rafael accepted this revision.Apr 21 2016, 8:31 AM
rafael edited edge metadata.

LGTM with a nit.

test/ELF/linkerscript-align.s
9

Any reason for not just checking in the script in Inputs?

This revision is now accepted and ready to land.Apr 21 2016, 8:31 AM
grimar added inline comments.Apr 21 2016, 8:35 AM
test/ELF/linkerscript-align.s
9

All (or at least most of) our tests has scripts inline atm. Actually I think it is
comfortable to have it in the same file. We have files with dozen
of little scripts, I don't think have dozen of inputs for them is better.

This revision was automatically updated to reflect the committed changes.