This is an archive of the discontinued LLVM Phabricator instance.

[test] Relax stderr expectations on targets with chatty output
ClosedPublic

Authored by labath on Apr 14 2016, 7:54 AM.

Details

Summary

On some android targets, a binary can produce additional garbage (e.g. warning messages from the
dynamic linker) on the standard error, which confuses some tests. This relaxes the stderr
expectations for targets known for their chattyness.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 53718.Apr 14 2016, 7:54 AM
labath retitled this revision from to [test] Relax stderr expectations on targets with chatty output.
labath updated this object.
labath added reviewers: tfiala, ovyalov.
labath added a subscriber: lldb-commits.
tberghammer accepted this revision.Apr 14 2016, 8:04 AM
tberghammer added a reviewer: tberghammer.

Looks good

This revision is now accepted and ready to land.Apr 14 2016, 8:04 AM
srhines added inline comments.Apr 14 2016, 8:13 AM
packages/Python/lldbsuite/test/lldbplatformutil.py
142 ↗(On Diff #53718)

I know it isn't ideal, but the stderr output isn't actually "garbage". It is just not a warning that lldb cares about, but it is perfectly valid to notify developers of an incorrect linking behavior.

This revision was automatically updated to reflect the committed changes.