This is an archive of the discontinued LLVM Phabricator instance.

Refactor debugging code, NFC.
ClosedPublic

Authored by thanm on Apr 11 2016, 1:37 PM.

Details

Summary

Refactor debugging routines to reduce code duplication. Remove a couple
of #include's that were not needed. Don't require MachineDominator as a
prereq for this pass (not needed).

These changes split off from http://reviews.llvm.org/D18827.

Diff Detail

Repository
rL LLVM

Event Timeline

thanm updated this revision to Diff 53314.Apr 11 2016, 1:37 PM
thanm retitled this revision from to Refactor debugging code, NFC..
thanm updated this object.
thanm added reviewers: wmi, gbiv, qcolombet.
thanm added subscribers: jevinskie, davidxl, llvm-commits.

Just a few comments, and this LGTM. Thanks for the patch!

lib/CodeGen/StackColoring.cpp
195 ↗(On Diff #53314)

Nit: Please clang-format this, and the other DEBUG statements nearby (specifically, I think there should be a space between dbgs() and <<).

196 ↗(On Diff #53314)

Nit: for (unsigned I = 0, E = BV.size(); I != E; ++I)

221 ↗(On Diff #53314)

Nit: for (unsigned I = 0, E = Intervals.size(); I != E; ++I)

223 ↗(On Diff #53314)

ISTM LiveInterval::dump will unconditionally dump things to dbgs(). So, maybe we should wrap this dump in DEBUG, too?

This revision is now accepted and ready to land.Apr 13 2016, 12:48 PM
thanm updated this revision to Diff 55286.Apr 27 2016, 12:13 PM

Incorporate code review feedback from gbiv.

Thanks George for your review comments (just getting back to this after a hiatus).
Will submit the changes. shortly.

This revision was automatically updated to reflect the committed changes.