Page MenuHomePhabricator

[mips] Remove duplicate tests and add missing prefixes for *-LABEL checks. NFC.
ClosedPublic

Authored by vkalintiris on Apr 1 2016, 6:05 AM.

Details

Summary

The only difference between the removed tests and the pre-existing
ones, is the materialization of the zero constant, which shouldn't
matter for these cases.

Diff Detail

Event Timeline

vkalintiris updated this revision to Diff 52356.Apr 1 2016, 6:05 AM
vkalintiris retitled this revision from to [mips] Remove duplicate tests and add missing prefixes for *-LABEL checks. NFC..
vkalintiris updated this object.
vkalintiris added a reviewer: dsanders.
vkalintiris added a subscriber: llvm-commits.
sdardis accepted this revision.Apr 13 2016, 8:43 AM
sdardis edited edge metadata.

LGTM. Agreed, tests with a fixed zero operand are not useful in this case.

Some pre-existing labels are nit worthy though, I've highlighted them inline.

test/CodeGen/Mips/llvm-ir/srem.ll
187

Shouldn't this be 64R6?

test/CodeGen/Mips/llvm-ir/urem.ll
215

I know you haven't changed this, but shouldn't this be 64R6?

This revision is now accepted and ready to land.Apr 13 2016, 8:43 AM
This revision was automatically updated to reflect the committed changes.