This is an archive of the discontinued LLVM Phabricator instance.

ELF: Correctly handle --whole-archive for thin archives.
ClosedPublic

Authored by pcc on Mar 31 2016, 12:51 PM.

Diff Detail

Event Timeline

pcc updated this revision to Diff 52266.Mar 31 2016, 12:51 PM
pcc retitled this revision from to ELF: Correctly handle --whole-archive for thin archives. Depends on D18664 Depends on D18666.
pcc updated this object.
pcc added reviewers: rafael, ruiu.
pcc added a subscriber: llvm-commits.
ruiu added inline comments.Mar 31 2016, 1:03 PM
ELF/Driver.cpp
74–76

Please make this a member function of LinkerDriver and remove OwningMBs parameter.

90–91

Add a comment.

pcc updated this revision to Diff 52288.Mar 31 2016, 2:16 PM
pcc marked 2 inline comments as done.
pcc retitled this revision from ELF: Correctly handle --whole-archive for thin archives. Depends on D18664 Depends on D18666 to ELF: Correctly handle --whole-archive for thin archives..
pcc updated this object.
  • Address review comments
ruiu accepted this revision.Mar 31 2016, 2:18 PM
ruiu edited edge metadata.

LGTM

test/ELF/whole-archive.s
36

You can remove --no-whole-archive

This revision is now accepted and ready to land.Mar 31 2016, 2:18 PM
This revision was automatically updated to reflect the committed changes.