This is an archive of the discontinued LLVM Phabricator instance.

Differential D18460

Add <atomic> to ThreadPool.h, since std::atomic is used
ClosedPublic

Authored by dim on Mar 24 2016, 1:39 PM.

Details

Reviewers
chandlerc
mehdi_amini
Commits
rG1fc06e9d9179: Merging r264335: --------------------------------------------------------------…
rG3a4f7ac669e5: Add <atomic> to ThreadPool.h, since std::atomic is used
rL264335: Add <atomic> to ThreadPool.h, since std::atomic is used
Summary

Apparently, when compiling with gcc 5.3.2 for powerpc64, the order of
headers is such that it gets an error about std::atomic<> use in
ThreadPool.h, since this header is not included explicitly. See also:

https://llvm.org/bugs/show_bug.cgi?id=27058

Fix this by including <atomic>. Patch by Bryan Drewery.

Diff Detail

Event Timeline

dim updated this revision to Diff 51597.Mar 24 2016, 1:39 PM
dim retitled this revision from to Add <atomic> to ThreadPool.h, since std::atomic is used.
dim updated this object.
dim added reviewers: mehdi_amini, chandlerc.
dim added subscribers: llvm-commits, bdrewery.
mehdi_amini accepted this revision.Mar 24 2016, 1:41 PM
mehdi_amini edited edge metadata.

Sure. Thanks.

This revision is now accepted and ready to land.Mar 24 2016, 1:41 PM
Closed by commit rL264335: Add <atomic> to ThreadPool.h, since std::atomic is used (authored by dim). · Explain WhyMar 24 2016, 1:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
llvm/
Support/
1 line

Diff 51597

include/llvm/Support/ThreadPool.h

Show All 27 Lines
#endif #endif
#include <future> #include <future>
#ifdef _MSC_VER #ifdef _MSC_VER
#pragma warning(pop) #pragma warning(pop)
#endif #endif
#include <atomic>
#include <condition_variable> #include <condition_variable>
#include <functional> #include <functional>
#include <memory> #include <memory>
#include <mutex> #include <mutex>
#include <queue> #include <queue>
#include <utility> #include <utility>
namespace llvm { namespace llvm {
▲ Show 20 Lines • Show All 93 Lines • Show Last 20 Lines