Page MenuHomePhabricator

Add <atomic> to ThreadPool.h, since std::atomic is used
ClosedPublic

Authored by dim on Mar 24 2016, 1:39 PM.

Details

Summary

Apparently, when compiling with gcc 5.3.2 for powerpc64, the order of
headers is such that it gets an error about std::atomic<> use in
ThreadPool.h, since this header is not included explicitly. See also:

https://llvm.org/bugs/show_bug.cgi?id=27058

Fix this by including <atomic>. Patch by Bryan Drewery.

Diff Detail

Repository
rL LLVM

Event Timeline

dim updated this revision to Diff 51597.Mar 24 2016, 1:39 PM
dim retitled this revision from to Add <atomic> to ThreadPool.h, since std::atomic is used.
dim updated this object.
dim added reviewers: mehdi_amini, chandlerc.
dim added subscribers: llvm-commits, bdrewery.
mehdi_amini accepted this revision.Mar 24 2016, 1:41 PM
mehdi_amini edited edge metadata.

Sure. Thanks.

This revision is now accepted and ready to land.Mar 24 2016, 1:41 PM
This revision was automatically updated to reflect the committed changes.