Page MenuHomePhabricator

[mips] Range check simm16
ClosedPublic

Authored by dsanders on Mar 24 2016, 3:39 AM.

Details

Summary

There are too many instructions to exhaustively test so addiu and lwc2 are
used as representative examples.

It should be noted that many memory instructions that should have simm16
range checking do not because it is also necessary to support the macro
of the same name which accepts simm32. The range checks for these occur in
the macro expansion.

Depends on D18436

Diff Detail

Event Timeline

dsanders updated this revision to Diff 51531.Mar 24 2016, 3:39 AM
dsanders retitled this revision from to [mips] Range check simm16.
dsanders updated this object.
dsanders added a reviewer: vkalintiris.
dsanders added a subscriber: llvm-commits.
vkalintiris accepted this revision.Mar 31 2016, 3:12 AM
vkalintiris edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Mar 31 2016, 3:12 AM
dsanders closed this revision.Mar 31 2016, 7:39 AM