This is an archive of the discontinued LLVM Phabricator instance.

Differential D18420

[sancov] adding leading zeros to coverage pct.
ClosedPublic

Authored by aizatsky on Mar 23 2016, 5:15 PM.

Details

Reviewers
kcc
vitalybuka
Commits
rGa4c651a2cc5e: [sancov] adding leading zeros to coverage pct.
rL264336: [sancov] adding leading zeros to coverage pct.
Summary

Using leading zeroes allows you to search for "000%" to find non-covered
items.

Diff Detail

Event Timeline

aizatsky updated this revision to Diff 51496.Mar 23 2016, 5:15 PM
aizatsky retitled this revision from to [sancov] adding leading zeros to coverage pct..
aizatsky updated this object.
aizatsky added reviewers: vitalybuka, kcc.Mar 23 2016, 5:15 PM
aizatsky added a subscriber: llvm-commits.
kcc accepted this revision.Mar 23 2016, 6:44 PM
kcc edited edge metadata.

LGTM
I am sure a UI expert could suggest us a better way, but this is better than we have now.

This revision is now accepted and ready to land.Mar 23 2016, 6:44 PM
aizatsky updated this revision to Diff 51569.Mar 24 2016, 10:24 AM
aizatsky edited edge metadata.

giving zeroes a shade of gray.

vitalybuka accepted this revision.Mar 24 2016, 10:36 AM
vitalybuka edited edge metadata.
vitalybuka added inline comments.
tools/sancov/sancov.cc
497

probably std::size_t{0} ->0u is enough

vitalybuka added inline comments.Mar 24 2016, 10:44 AM
tools/sancov/sancov.cc
502

std::string Num = std::to_string(Pct);
return std::string(3-Num.size(), ''0") + Num;

aizatsky updated this revision to Diff 51590.Mar 24 2016, 1:21 PM
aizatsky marked an inline comment as done.
aizatsky edited edge metadata.

review

aizatsky updated this revision to Diff 51591.Mar 24 2016, 1:22 PM

nit

aizatsky added a comment.Mar 24 2016, 1:22 PM

ptal

tools/sancov/sancov.cc
497

Not really. You need 0ul, but that makes this code not cross-platform.

vitalybuka added a comment.Mar 24 2016, 1:28 PM

LGTM

Closed by commit rL264336: [sancov] adding leading zeros to coverage pct. (authored by aizatsky). · Explain WhyMar 24 2016, 1:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
sancov/
20 lines

Diff 51591

tools/sancov/sancov.cc

Show All 40 Lines
#include "llvm/Support/Regex.h" #include "llvm/Support/Regex.h"
#include "llvm/Support/Signals.h" #include "llvm/Support/Signals.h"
#include "llvm/Support/SpecialCaseList.h" #include "llvm/Support/SpecialCaseList.h"
#include "llvm/Support/TargetRegistry.h" #include "llvm/Support/TargetRegistry.h"
#include "llvm/Support/TargetSelect.h" #include "llvm/Support/TargetSelect.h"
#include "llvm/Support/ToolOutputFile.h" #include "llvm/Support/ToolOutputFile.h"
#include "llvm/Support/raw_ostream.h" #include "llvm/Support/raw_ostream.h"
#include <algorithm>
#include <set> #include <set>
#include <stdio.h> #include <stdio.h>
#include <string> #include <string>
#include <utility> #include <utility>
#include <vector> #include <vector>
using namespace llvm; using namespace llvm;
▲ Show 20 Lines • Show All 428 Lines • ▼ Show 20 Lines for (char Ch : S) {
default: default:
Result.push_back(Ch); Result.push_back(Ch);
break; break;
} }
} }
return Result; return Result;
} }
// Adds leading zeroes wrapped in 'lz' style.
// Leading zeroes help locate 000% coverage.
static std::string formatHtmlPct(size_t Pct) {
Pct = std::max(std::size_t{0}, std::min(std::size_t{100}, Pct));
vitalybukaUnsubmitted
Not Done
ReplyInline Actions

probably std::size_t{0} ->0u is enough

vitalybuka: probably std::size_t{0} ->0u is enough
aizatskyAuthorUnsubmitted
Not Done
ReplyInline Actions

Not really. You need 0ul, but that makes this code not cross-platform.

aizatsky: Not really. You need 0ul, but that makes this code not cross-platform.
std::string Num = std::to_string(Pct);
std::string Zeroes(3 - Num.size(), '0');
if (!Zeroes.empty())
Zeroes = "<span class='lz'>" + Zeroes + "</span>";
vitalybukaUnsubmitted
Done
ReplyInline Actions

std::string Num = std::to_string(Pct);
return std::string(3-Num.size(), ''0") + Num;

vitalybuka: std::string Num = std::to_string(Pct); return std::string(3-Num.size(), ''0") + Num;
return Zeroes + Num;
}
static std::string anchorName(std::string Anchor) { static std::string anchorName(std::string Anchor) {
llvm::MD5 Hasher; llvm::MD5 Hasher;
llvm::MD5::MD5Result Hash; llvm::MD5::MD5Result Hash;
Hasher.update(Anchor); Hasher.update(Anchor);
Hasher.final(Hash); Hasher.final(Hash);
SmallString<32> HexString; SmallString<32> HexString;
llvm::MD5::stringifyResult(Hash, HexString); llvm::MD5::stringifyResult(Hash, HexString);
▲ Show 20 Lines • Show All 379 Lines • ▼ Show 20 Lines for (auto FileName : Files) {
if (FC.first == 0) { if (FC.first == 0) {
NotCoveredFilesCount++; NotCoveredFilesCount++;
continue; continue;
} }
size_t CovPct = FC.second == 0 ? 100 : 100 * FC.first / FC.second; size_t CovPct = FC.second == 0 ? 100 : 100 * FC.first / FC.second;
OS << "<tr><td><a href=\"#" << anchorName(FileName) << "\">" OS << "<tr><td><a href=\"#" << anchorName(FileName) << "\">"
<< stripPathPrefix(FileName) << "</a></td>" << stripPathPrefix(FileName) << "</a></td>"
<< "<td>" << CovPct << "%</td>" << "<td>" << formatHtmlPct(CovPct) << "%</td>"
<< "<td>" << FC.first << " (" << FC.second << ")" << "<td>" << FC.first << " (" << FC.second << ")"
<< "</tr>\n"; << "</tr>\n";
} }
OS << "</table>\n"; OS << "</table>\n";
OS << "</details>\n"; OS << "</details>\n";
// Not covered files. // Not covered files.
if (NotCoveredFilesCount) { if (NotCoveredFilesCount) {
Show All 21 Lines for (auto FileName : Files) {
OS << "<div class='fnlist'>\n"; OS << "<div class='fnlist'>\n";
auto &FileFnCoverage = FnCoverageByFile[FileName]; auto &FileFnCoverage = FnCoverageByFile[FileName];
for (const auto &P : FileFnCoverage) { for (const auto &P : FileFnCoverage) {
std::string FunctionName = P.first.FunctionName; std::string FunctionName = P.first.FunctionName;
OS << "<div class='fn' style='order: " << P.second << "'>"; OS << "<div class='fn' style='order: " << P.second << "'>";
OS << "<span class='pct'>" << P.second << "%</span>&nbsp;"; OS << "<span class='pct'>" << formatHtmlPct(P.second)
<< "%</span>&nbsp;";
OS << "<span class='name'><a href=\"#" OS << "<span class='name'><a href=\"#"
<< anchorName(FileName + "::" + FunctionName) << "\">"; << anchorName(FileName + "::" + FunctionName) << "\">";
OS << escapeHtml(FunctionName) << "</a></span>"; OS << escapeHtml(FunctionName) << "</a></span>";
OS << "</div>\n"; OS << "</div>\n";
} }
OS << "</div></details>\n"; OS << "</div></details>\n";
ErrorOr<std::unique_ptr<MemoryBuffer>> BufOrErr = ErrorOr<std::unique_ptr<MemoryBuffer>> BufOrErr =
▲ Show 20 Lines • Show All 168 Lines • ▼ Show 20 Lines void printReport(raw_ostream &OS) const {
OS << ".notcovered { background: #F77; }\n"; OS << ".notcovered { background: #F77; }\n";
OS << ".mixed { background: #FF7; }\n"; OS << ".mixed { background: #FF7; }\n";
OS << "summary { font-weight: bold; }\n"; OS << "summary { font-weight: bold; }\n";
OS << "details > summary + * { margin-left: 1em; }\n"; OS << "details > summary + * { margin-left: 1em; }\n";
OS << ".fnlist { display: flex; flex-flow: column nowrap; }\n"; OS << ".fnlist { display: flex; flex-flow: column nowrap; }\n";
OS << ".fn { display: flex; flex-flow: row nowrap; }\n"; OS << ".fn { display: flex; flex-flow: row nowrap; }\n";
OS << ".pct { width: 3em; text-align: right; margin-right: 1em; }\n"; OS << ".pct { width: 3em; text-align: right; margin-right: 1em; }\n";
OS << ".name { flex: 2; }\n"; OS << ".name { flex: 2; }\n";
OS << ".lz { color: lightgray; }\n";
OS << "</style>\n"; OS << "</style>\n";
OS << "<title>" << Title << "</title>\n"; OS << "<title>" << Title << "</title>\n";
OS << "</head>\n"; OS << "</head>\n";
OS << "<body>\n"; OS << "<body>\n";
// Title // Title
OS << "<h1>" << Title << "</h1>\n"; OS << "<h1>" << Title << "</h1>\n";
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines