Page MenuHomePhabricator

[tsan] Build TSan dylibs for iOS-style simulators
ClosedPublic

Authored by dcoughlin on Mar 18 2016, 1:17 PM.

Details

Summary

This proposed patch updates the compiler-rt cmake to build TSan dylibs for iOS-style simulators when the corresponding COMPILER_RT_ENABLE_FOO_OS setting is enabled.

Diff Detail

Event Timeline

dcoughlin updated this revision to Diff 51063.Mar 18 2016, 1:17 PM
dcoughlin retitled this revision from to [tsan] Build TSan dylibs for iOS-style simulators.
dcoughlin updated this object.
dcoughlin added reviewers: samsonov, kubamracek.
dcoughlin added a subscriber: llvm-commits.
kubamracek added inline comments.Mar 18 2016, 2:51 PM
cmake/config-ix.cmake
400

Unrelated to this patch, but shouldn't this be if(DARWIN_${platform}sim_ARCHS)?

beanz accepted this revision.Mar 18 2016, 3:05 PM
beanz edited edge metadata.

Patch LGTM.

cmake/config-ix.cmake
400

Yes, yes it should.

This revision is now accepted and ready to land.Mar 18 2016, 3:05 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r263910.