This is an archive of the discontinued LLVM Phabricator instance.

Differential D17937

ARM: Support relative references using the PREL31 symbol variant.
ClosedPublic

Authored by pcc on Mar 7 2016, 12:53 PM.

Details

Reviewers
rengolin
• rafael
Commits
rGaba16fca5de0: ARM: Support relative references using the PREL31 symbol variant.
rL263156: ARM: Support relative references using the PREL31 symbol variant.

Diff Detail

Event Timeline

pcc updated this revision to Diff 49988.Mar 7 2016, 12:53 PM
pcc retitled this revision from to ARM: Support relative references using the PREL31 symbol variant..
pcc updated this object.
pcc added a reviewer: • rafael.
pcc added a subscriber: llvm-commits.
Herald added subscribers: rengolin, aemerson. · View Herald TranscriptMar 7 2016, 12:53 PM
rengolin accepted this revision.Mar 9 2016, 9:42 PM
rengolin added a reviewer: rengolin.

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 9 2016, 9:42 PM
Closed by commit rL263156: ARM: Support relative references using the PREL31 symbol variant. (authored by pcc). · Explain WhyMar 10 2016, 11:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
ARM/
MCTargetDesc/
3 lines
test/
MC/
ARM/
14 lines

Diff 49988

lib/Target/ARM/MCTargetDesc/ARMELFObjectWriter.cpp

Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines case FK_Data_4:
case MCSymbolRefExpr::VK_TLSGD: case MCSymbolRefExpr::VK_TLSGD:
llvm_unreachable("unimplemented"); llvm_unreachable("unimplemented");
case MCSymbolRefExpr::VK_GOTTPOFF: case MCSymbolRefExpr::VK_GOTTPOFF:
Type = ELF::R_ARM_TLS_IE32; Type = ELF::R_ARM_TLS_IE32;
break; break;
case MCSymbolRefExpr::VK_ARM_GOT_PREL: case MCSymbolRefExpr::VK_ARM_GOT_PREL:
Type = ELF::R_ARM_GOT_PREL; Type = ELF::R_ARM_GOT_PREL;
break; break;
case MCSymbolRefExpr::VK_ARM_PREL31:
Type = ELF::R_ARM_PREL31;
break;
} }
break; break;
case ARM::fixup_arm_blx: case ARM::fixup_arm_blx:
case ARM::fixup_arm_uncondbl: case ARM::fixup_arm_uncondbl:
switch (Modifier) { switch (Modifier) {
case MCSymbolRefExpr::VK_PLT: case MCSymbolRefExpr::VK_PLT:
Type = ELF::R_ARM_CALL; Type = ELF::R_ARM_CALL;
break; break;
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines

test/MC/ARM/symbol-variants.s

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines
@ CHECK: 5c R_ARM_TLS_CALL f23 @ CHECK: 5c R_ARM_TLS_CALL f23
@ tlsdesc @ tlsdesc
.word f24(TLSDESC) .word f24(TLSDESC)
.word f25(tlsdesc) .word f25(tlsdesc)
@ CHECK: 60 R_ARM_TLS_GOTDESC f24 @ CHECK: 60 R_ARM_TLS_GOTDESC f24
@ CHECK: 64 R_ARM_TLS_GOTDESC f25 @ CHECK: 64 R_ARM_TLS_GOTDESC f25
@ prel31 (relative)
.word f26(PREL31)-.
.word f27(prel31)-.
@CHECK: 68 R_ARM_PREL31 f26
@CHECK: 6c R_ARM_PREL31 f27
@ got_prel @ got_prel
.word f26(GOT_PREL) + (. - .Lsym) .word f28(GOT_PREL) + (. - .Lsym)
ldr r3, =f27(GOT_PREL) ldr r3, =f29(GOT_PREL)
@ CHECK: 68 R_ARM_GOT_PREL f26 @ CHECK: 70 R_ARM_GOT_PREL f28
@ CHECK: 70 R_ARM_GOT_PREL f27 @ CHECK: 78 R_ARM_GOT_PREL f29