This is an archive of the discontinued LLVM Phabricator instance.

Remove CoreDriver.
ClosedPublic

Authored by ruiu on Feb 28 2016, 12:12 PM.

Details

Summary

CoreDriver implements a driver for a hypothetical platform.
It is intended to be used in unittests. However, it is actually
redundant because the features are tested using the real driver
for the real platforms. So we can remove this.

Diff Detail

Event Timeline

ruiu updated this revision to Diff 49326.Feb 28 2016, 12:12 PM
ruiu retitled this revision from to Remove CoreDriver..
ruiu updated this object.
ruiu added reviewers: pete, rafael.
ruiu added a subscriber: llvm-commits.
rafael edited edge metadata.Feb 28 2016, 3:26 PM

I would love to see this, but it is probably Pete's call.

pete edited edge metadata.Feb 28 2016, 4:26 PM
pete added a subscriber: pete.

I'm fine with it, but going to pass the final call to Lang as he owns the Darwin side of lld.

Cheers
Pete

ruiu added a reviewer: lhames.Mar 1 2016, 10:00 AM
lhames accepted this revision.Mar 1 2016, 3:33 PM
lhames edited edge metadata.

Seems reasonable. Go ahead Rui.

This revision is now accepted and ready to land.Mar 1 2016, 3:33 PM
ruiu closed this revision.Mar 1 2016, 3:48 PM

Thanks. Committed as r262421.

test/core/undef-coalesce.objtxt