Page MenuHomePhabricator

[zorg] Correcting a bug in ClangLTO3StageBuilder.py.
ClosedPublic

Authored by sqlbyme on Feb 26 2016, 4:48 PM.

Details

Reviewers
gkistanova
Summary

Patch by Galina Kistanova & Mike Edwards

Galina fixed a bug by producing a much more elegant way to extract the current clang release version, which we need to set as a Buildbot property.

I fixed the fact that I had labeled the property incorrectly. It is now labeled correctly: clang_ver
I also corrected some of the names for build steps so they are more descriptive.

Diff Detail

Event Timeline

sqlbyme updated this revision to Diff 49268.Feb 26 2016, 4:48 PM
sqlbyme retitled this revision from to [zorg] Correcting a bug in ClangLTO3StageBuilder.py..
sqlbyme updated this object.
sqlbyme added a reviewer: gkistanova.
sqlbyme added a project: Restricted Project.
sqlbyme added a subscriber: llvm-commits.
gkistanova accepted this revision.Feb 26 2016, 5:16 PM
gkistanova edited edge metadata.

LGTM

Thanks

Galina

This revision is now accepted and ready to land.Feb 26 2016, 5:16 PM

Committed r262097

sqlbyme closed this revision.Feb 26 2016, 5:33 PM
silvas added a subscriber: silvas.Feb 27 2016, 12:12 AM

Why do you need the version in the first place? Just there should be a plain clang in the directory too.

Really though, we should be checking every binary in both directories. How about adding a script utils/diffbindirs.py and then just call python utils/diffbindirs.py tools/clang/stage2-bins/bin/ tools/clang/stage2-bins/tools/clang/stage3-bins/bin/?

I will admit that I do not understand enough about how diff works to be confident that diff'ing the symbolic link to the binary would produce the same result as diff'ing the binary itself. It seems to. Probably dumb, but I wanted to be able to say with absolute certainty that I was diff'ing the just built binaries.

That said, I like your idea of a script that will diff all of the files in the stage2-bins and stage3-bins directories. I'll work on that.