Page MenuHomePhabricator

Introduce DominanceFrontierAnalysis to the new PassManager to compute DominanceFrontier. NFC
ClosedPublic

Authored by etherzhhb on Feb 24 2016, 6:47 AM.

Details

Summary

I am going to introduce the analysis passes to compute PostDominators, DominanceFrontier and RegionInfo in the new pass manager, such that later we can rewrite passes in Polly in new pass manager style and make interprocedural analysis in Polly become easier.

This is the DominanceFrontier part.

Diff Detail

Repository
rL LLVM

Event Timeline

etherzhhb updated this revision to Diff 48926.Feb 24 2016, 6:47 AM
etherzhhb retitled this revision from to Introduce DominanceFrontierAnalysis to the new PassManager to compute DominanceFrontier. NFC.
etherzhhb updated this object.
etherzhhb added reviewers: chandlerc, grosser, jdoerfert.
etherzhhb set the repository for this revision to rL LLVM.
etherzhhb added a project: Restricted Project.
etherzhhb added a subscriber: llvm-commits.
grosser accepted this revision.Feb 25 2016, 5:15 AM
grosser edited edge metadata.

Hi ether,

this patch looks good to me as well. I know we currently have no actual dominance frontier tests, but I think this would be a good occasion to add one. Domfrontier is hopefully removed at some point in time, but until this time comes it is good to have at least some basic test coverage.

Best,
Tobias

This revision is now accepted and ready to land.Feb 25 2016, 5:15 AM

Hi ether,

this patch looks good to me as well. I know we currently have no actual dominance frontier tests, but I think this would be a good occasion to add one. Domfrontier is hopefully removed at some point in time, but until this time comes it is good to have at least some basic test coverage.

Best,
Tobias

I am going to add one from RegionInfo tests

This revision was automatically updated to reflect the committed changes.