Page MenuHomePhabricator

[MSan] Endianness should not matter while printing a byte
ClosedPublic

Authored by mohit.bhakkad on Feb 24 2016, 12:36 AM.

Details

Reviewers
eugenis
Summary

Print the hex digits of each byte in the most significant first order, and print different bytes in the memory order.

Diff Detail

Repository
rL LLVM

Event Timeline

mohit.bhakkad retitled this revision from to [MSan] Endianness should not matter while printing a byte.
mohit.bhakkad updated this object.
mohit.bhakkad added a reviewer: eugenis.
mohit.bhakkad set the repository for this revision to rL LLVM.
eugenis edited edge metadata.Feb 25 2016, 1:28 PM

Looks good, but it should be in the same commit as the test change, otherwise it would break the tests on little-endian targets.

mohit.bhakkad added a comment.EditedFeb 25 2016, 10:23 PM

Looks good, but it should be in the same commit as the test change, otherwise it would break the tests on little-endian targets.

Sure, I will commit both revisions together. Are you okay with new revision of D17264?

eugenis accepted this revision.Feb 25 2016, 10:29 PM
eugenis edited edge metadata.

yes

This revision is now accepted and ready to land.Feb 25 2016, 10:29 PM